Add tests for BasePackageLoader and DefaultPackageLoader (#39 part 1)

- BasePackageLoader tests
- DefaultPackageLoader tests
- Additional json files used taken from fpl and sushi

package.json

@@ -51,6 +51,7 @@
     "eslint-config-prettier": "^9.1.0",
     "jest": "^29.7.0",
     "jest-extended": "^4.0.2",
+    "jest-mock-extended": "^4.0.0-beta1",
     "opener": "^1.5.2",
     "prettier": "^3.3.3",
     "ts-jest": "^29.1.2",

src/loader/BasePackageLoader.ts

@@ -34,8 +34,7 @@ export class BasePackageLoader implements PackageLoader {
     }
 
     // If it's a "dev" version, but it wasn't found in the cache, fall back to using the current version
-    // TODO: Does this actually check for the dev version prior to giving up?
-    if (version === 'dev') {
+    if (version === 'dev' && !this.packageCache.isPackageInCache(name, version)) {
       this.log(
         'info',
         `Falling back to ${name}#current since ${packageLabel} is not locally cached. To avoid this, add ${packageLabel} to your local FHIR cache by building it locally with the HL7 FHIR IG Publisher.`
@@ -127,6 +126,7 @@ export class BasePackageLoader implements PackageLoader {
           this.loadResourceFromCache(resourcePath, packageName, packageVersion);
         } catch {
           // swallow this error because some JSON files will not be resources
+          this.log('info', `JSON file at path ${resourcePath} was not FHIR resource`);
         }
       });
   }

test/loader/DefaultPackageLoader.test.ts

@@ -0,0 +1,35 @@
+import { loggerSpy } from '../testhelpers';
+import { mock } from 'jest-mock-extended';
+import { BasePackageLoader, BasePackageLoaderOptions } from '../../src/loader/BasePackageLoader';
+import { LoadStatus } from '../../src/loader/PackageLoader';
+import { PackageDB } from '../../src/db';
+import { PackageCache } from '../../src/cache';
+import { RegistryClient } from '../../src/registry';
+import { CurrentBuildClient } from '../../src/current';
+
+describe('DefaultPackageLoader', () => {
+
+    async function makeMyDefaultPackageLoader(options: BasePackageLoaderOptions) : Promise<BasePackageLoader> {
+        const packageDBMock = mock<PackageDB>();
+        const packageCacheMock = mock<PackageCache>();
+        const registryClientMock = mock<RegistryClient>();
+        const currentBuildClientMock = mock<CurrentBuildClient>();
+        const loader = new BasePackageLoader(
+            packageDBMock,
+            packageCacheMock,
+            registryClientMock,
+            currentBuildClientMock,
+            { log: options.log }
+            );
+        return loader;
+    }
+
+    it('should create a package loader with mock default package loader' , async () => {
+        const loader = await makeMyDefaultPackageLoader({log: loggerSpy.log});
+        loader.getPackageLoadStatus = jest.fn().mockReturnValueOnce(LoadStatus.LOADED);
+
+        const result = await loader.loadPackage('some.ig', '1.2.3');
+        expect(result).toBe(LoadStatus.LOADED);
+        expect(loader.getPackageLoadStatus).toHaveBeenCalledWith('some.ig', '1.2.3');
+    });
+});