Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text editors support line wrapping #159

Merged
merged 6 commits into from
Jun 21, 2024
Merged

Text editors support line wrapping #159

merged 6 commits into from
Jun 21, 2024

Conversation

KaelynJefferson
Copy link
Collaborator

This PR includes:

  • Functionality to display code with line wrapping in the code editors
  • Checkbox for user selection of this functionality

mint-thompson
mint-thompson previously approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@mint-thompson mint-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray for line wrapping!

cmoesel
cmoesel requested changes Jun 12, 2024
View reviewed changes
Copy link
Member

@cmoesel cmoesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature works very well. I like it!

I noticed some inconsistencies in how we name things in the code. I think it might be easier for future maintainers if we are consistent in our naming.

src/App.js Outdated Show resolved Hide resolved
src/components/FSHControls.js Outdated Show resolved Hide resolved
jafeltra
jafeltra requested changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@jafeltra jafeltra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few comments inline. Let me know if you want to talk about any of them, especially the one about the test.

src/components/FSHControls.js Outdated Show resolved Hide resolved
src/components/FSHControls.js Outdated Show resolved Hide resolved
src/tests/components/FSHControls.test.js Outdated Show resolved Hide resolved
@KaelynJefferson
Removed use of local state variable in FSHControls. Added tests for l…
fd1e064 
…ine wrapping in editor. Added one test for basic app renders within App.js.
jafeltra
jafeltra approved these changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@jafeltra jafeltra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! The code and tests make sense and work as expected.

Since this configuration option is likely a personal preference that is pretty consistent, it might be nice to have the browser store this setting so it stays across refreshes and reopening the page. But that would be a separate task, if others even like it.

cmoesel
cmoesel approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@cmoesel cmoesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well! Thanks for the tests!

@cmoesel cmoesel merged commit 2a0c144 into master Jun 21, 2024
4 checks passed
@cmoesel cmoesel deleted the editor-line-wrapping branch June 21, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafeltra jafeltra jafeltra approved these changes

@cmoesel cmoesel cmoesel approved these changes

@mint-thompson mint-thompson mint-thompson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KaelynJefferson @cmoesel @mint-thompson @jafeltra