Update automatically loaded dependencies #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmoesel
requested changes
Feb 22, 2024
There was a problem hiding this comment.
Thanks for doing this. There is a little squishiness with R4/R4B that works now but could cause problems in the future if new automatic dependencies are added with specific R4 or R4B packages. I've also suggested a couple of other possible refactorings to consider. Since we don't support as many FHIR versions as SUSHI does, I think we can have a simpler approach than SUSHI's.
mint-thompson
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates FSH Online to automatically load dependencies that are more in line with SUSHI's current implementation. We use the
latestversion ofhl7.fhir.uv.tools(rather thancurrent, like SUSHI) because FSH Online does not supportcurrentversions at the moment. Thehl7.terminologyandhl7.fhir.uv.extensionspackages are now loaded based on the current FHIR version being used, similar to SUSHI.I made a small refactor to the code in the second commit because it seemed simpler.
You can test this by changing to the different FHIR versions FSH Online supports and ensuring that the proper packages are loaded for each one.