More work towards supporting mixed-topology meshes #3590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to be crashing in sparsity pattern builder at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on @chrisrichardson's work in this branch to support mixed-topology meshes.
The idea is to allow
fem::FunctionSpaceto have multiple elements/dofmaps for each cell type. Similarly,fem::Formnow can have more than oneintegral_datafor a given subdomain ID, one for each kernel type. In the assembler, we simply loop over each kernel type. There are no changes to the lowest level assemblers. Currently, it only works for cell integrals and matrix assembly, but this design should easily generalise to assembling vectors/scalars and exterior facet integrals. The design should also generalise to interior facet integrals, but this will need more work because we need to generate kernels and access the DOF maps for each compatible combination of cell types etc.It's just a draft for now; any comments on the general design would be much appreciated. If we think this is the right approach, I can modify the other assemblers and add support for exterior facet integrals.