Connecting to base sections #484

sanbrock · 2024-12-10T14:45:03Z

No description provided.

lukaspie

The content looks good in what it's trying to achieve. I am still unsure if connectin NXentry to ActivityStep is correct.

I left some comments on docstrings. Would also be good to have the changes in the PR summary to keep track later on.

src/pynxtools/nomad/schema.py

…es; only support the concept Entry and no more entry

sanbrock and others added 8 commits December 1, 2024 19:24

initial skeleton for NeXus App

7438daa

a minimalistic App

bbe35e3

Merge branch 'master' into nomad-app

3b5f03d

fix merge

518d511

comments added as suggested in code review

7dfd332

Measurement,ActivityStep

578734e

extend normalisation and make NXprocess also an ActivityStep

06ecfde

Merge branch 'master' into connecting_to_base_sections

3e682b8

sanbrock requested a review from lukaspie December 12, 2024 00:18

lukaspie approved these changes Dec 12, 2024

View reviewed changes

src/pynxtools/nomad/schema.py Outdated Show resolved Hide resolved

sanbrock added 4 commits December 12, 2024 18:01

fix separation between Instrument base sections from different packag…

b2fcc6a

…es; only support the concept Entry and no more entry

fixing doc string

61f4f2c

add NXdata as an ActivityResult

e5c9859

avoid double-inheritance of NexusMeasurement

a780dbb

sanbrock merged commit a142519 into master Dec 13, 2024
17 checks passed

sanbrock deleted the connecting_to_base_sections branch December 13, 2024 15:38

Provide feedback