Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small updates to multi reader #470

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

lukaspie
Copy link
Collaborator

This solves two problems:

  1. If, in your config file, you have a list with a wildcard like this "peakPEAK[peak*]/data/@xes":["@attrs:component*/kx, @attrs:component*/ky"], all of these values in the list gets replace as for non-list cases.
  2. If you have multiple options to resolve a wildcard value like
    "peakPEAK[peak*]/intensity":"['@attrs:component*/data_cps', '@attrs:component*/data']", where the reader first tries to fill from the path component*/data_cps and then from @attrs:component*/data', there was an issue with the dict iterator before if the first attempt at filling does not work. This is fixed here.

Copy link
Contributor

@RonHildebrandt RonHildebrandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the first part.
The second, with the .copy is most probably necessary, as here during iteration some changes were made? Anyway, I think its always saver todo it like this.

Therefore: lgtm

@lukaspie
Copy link
Collaborator Author

The second, with the .copy is most probably necessary, as here during iteration some changes were made? Anyway, I think its always saver todo it like this.

Exactly, that was the problem. Thanks for the review.

@lukaspie lukaspie merged commit f721a26 into master Nov 21, 2024
14 checks passed
@lukaspie lukaspie deleted the small-updates-to-multi-reader branch November 21, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants