Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init commit for citation. #439

Merged
merged 21 commits into from
Sep 30, 2024
Merged

init commit for citation. #439

merged 21 commits into from
Sep 30, 2024

Conversation

RubelMozumder
Copy link
Collaborator

@RubelMozumder RubelMozumder commented Sep 24, 2024

This is a initial commit for citation. Check the contributor list if your ORCI is correct. If I miss someone please, include them.

@rettigl would share your ORCID here? I can include it.

pyproject.toml Outdated Show resolved Hide resolved
src/pynxtools/__init__.py Outdated Show resolved Hide resolved
@rettigl
Copy link
Collaborator

rettigl commented Sep 24, 2024

I might have missed the discussion on this, but wouldn't it be better to implement a mechanism that automatically keeps the version tags up to date, rather than only checking them and have the user fix them?

@rettigl
Copy link
Collaborator

rettigl commented Sep 24, 2024

@rettigl would share your ORCID here? I can include it.

0000-0002-0725-6696

@RubelMozumder
Copy link
Collaborator Author

@rettigl would share your ORCID here? I can include it.

0000-0002-0725-6696

Included.

@RubelMozumder
Copy link
Collaborator Author

I might have missed the discussion on this, but wouldn't it be better to implement a mechanism that automatically keeps the version tags up to date, rather than only checking them and have the user fix them?

I added GH action to check the version compatibility among git tag or PyPI tag, version in citation and version defined inside software.

@rettigl
Copy link
Collaborator

rettigl commented Sep 24, 2024

I might have missed the discussion on this, but wouldn't it be better to implement a mechanism that automatically keeps the version tags up to date, rather than only checking them and have the user fix them?

I added GH action to check the version compatibility among git tag or PyPI tag, version in citation and version defined inside software.

Is the citation file itself missing, or am I missing something?

@RubelMozumder
Copy link
Collaborator Author

I might have missed the discussion on this, but wouldn't it be better to implement a mechanism that automatically keeps the version tags up to date, rather than only checking them and have the user fix them?

I added GH action to check the version compatibility among git tag or PyPI tag, version in citation and version defined inside software.

Is the citation file itself missing, or am I missing something?

Sorry, CITATION.cff was missing.

pyproject.toml Outdated Show resolved Hide resolved
CITATION.cff Outdated Show resolved Hide resolved
@RubelMozumder RubelMozumder marked this pull request as ready for review September 27, 2024 08:33
Copy link
Collaborator

@lukaspie lukaspie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestions for the abstract.

CITATION.cff Outdated Show resolved Hide resolved
CITATION.cff Outdated Show resolved Hide resolved
CITATION.cff Outdated Show resolved Hide resolved
Co-authored-by: Lukas Pielsticker <[email protected]>
RubelMozumder and others added 3 commits September 30, 2024 11:18
CITATION.cff Outdated Show resolved Hide resolved
CITATION.cff Outdated Show resolved Hide resolved
CITATION.cff Outdated Show resolved Hide resolved
CITATION.cff Show resolved Hide resolved
@RubelMozumder RubelMozumder merged commit 9e8eded into master Sep 30, 2024
14 checks passed
@lukaspie lukaspie deleted the citation branch September 30, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants