-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation based on hdf tree traversal #333
Open
domna
wants to merge
30
commits into
master
Choose a base branch
from
hdf-based-validation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9517068942Details
💛 - Coveralls |
domna
force-pushed
the
hdf-based-validation
branch
from
May 17, 2024 11:26
3483bd4
to
4fff6a2
Compare
domna
force-pushed
the
hdf-based-validation
branch
from
June 7, 2024 15:09
c040e52
to
9eab38c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sketch of a hdf tree traversal by the rough ideas I already had in my head I didn't want to forget during my holidays. With the additional functions I added during the development #323 this easily checks for all the elements in the whole tree dynamically. Mainly it misses the actual checking routines for fields and attributes. Generally, it seems it's much more straightforward than the verification in the dict, because we have much less specialities we need to consider. However, it could be that the performance is not as good, because we traverse the hdf each time. But I tried to build a cached recursive function to balance that off.
This can be used as a proper basis for #133.
Development branches:
Needs care on the following points:
entry
levelgenerate:
But expecting field
"/ENTRY[entry]/hdf5_validator_2_program_name": "None"
as well.