Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XPS vamas sub-reader: enhance data extraction #229

Closed
wants to merge 1 commit into from

Conversation

lukaspie
Copy link
Collaborator

@lukaspie lukaspie commented Feb 2, 2024

This is a draft for enhancing the existing Vamas XPS reader.
The Vamas reader reads .vms files, which is the current ISO standard data transfer format (ISO 14976).

  • Write CPS data to file
  • Extract units for quantities
  • Parse vamas files of type IRREGULAR

@lukaspie lukaspie self-assigned this Feb 2, 2024
@coveralls
Copy link

coveralls commented Feb 2, 2024

Pull Request Test Coverage Report for Build 7756531500

  • 0 of 10 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 44.559%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pynxtools/dataconverter/readers/xps/vms/vamas.py 0 10 0.0%
Files with Coverage Reduction New Missed Lines %
pynxtools/dataconverter/convert.py 1 76.92%
pynxtools/dataconverter/readers/shared/map_concepts/mapping_functors.py 1 11.86%
Totals Coverage Status
Change from base Build 7755071875: -0.03%
Covered Lines: 4906
Relevant Lines: 11010

💛 - Coveralls

@lukaspie
Copy link
Collaborator Author

Closed as this will be addressed in the xps reader plugin: FAIRmat-NFDI/pynxtools-xps#10

@lukaspie lukaspie closed this Feb 21, 2024
@lukaspie lukaspie deleted the xps-vms-reader branch June 4, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants