Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XPS sub-reader for PHI Versaprobe data #227

Closed
wants to merge 28 commits into from

Conversation

lukaspie
Copy link
Collaborator

@lukaspie lukaspie commented Feb 2, 2024

  • Parser for PHI Versaprobe .spe (regular spectra) and .pro (sputter depth profiling)
  • New config file to account for these data sets

Still missing:

  • Correct parsing of binary encoded data
  • Mapping of optional instrument devices (sputter source, neutral ion gun, C60 gun, defect positioner) to the config file
  • Example with ELN data

This PR depends on #220 and should be merged afterwards/together.

Resolves FAIRmat-NFDI/pynxtools-xps#1.

@lukaspie lukaspie requested a review from domna February 2, 2024 07:25
@coveralls
Copy link

coveralls commented Feb 2, 2024

Pull Request Test Coverage Report for Build 7904633964

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • -296 of 680 (56.47%) changed or added relevant lines in 6 files are covered.
  • 28 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.6%) to 45.156%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pynxtools/dataconverter/readers/xps/reader.py 12 13 92.31%
pynxtools/dataconverter/readers/xps/sle/sle_specs.py 0 1 0.0%
pynxtools/dataconverter/readers/xps/txt/txt_scienta.py 0 1 0.0%
pynxtools/dataconverter/readers/xps/phi/phi_data_model.py 321 331 96.98%
pynxtools/dataconverter/readers/xps/phi/spe_pro_phi.py 48 331 14.5%
Files with Coverage Reduction New Missed Lines %
tests/dataconverter/test_writer.py 1 96.77%
pynxtools/dataconverter/convert.py 2 76.15%
pynxtools/dataconverter/readers/em_spctrscpy/utils/hspy/em_hspy_adf.py 2 11.38%
pynxtools/dataconverter/readers/em_spctrscpy/utils/hspy/em_hspy_eels.py 3 9.38%
pynxtools/dataconverter/readers/em_spctrscpy/utils/hspy/em_hspy_xray.py 4 8.59%
pynxtools/nexus/nexus.py 16 73.39%
Totals Coverage Status
Change from base Build 7728915365: 0.6%
Covered Lines: 5272
Relevant Lines: 11675

💛 - Coveralls

@domna
Copy link
Collaborator

domna commented Feb 2, 2024

Just leaving this link for the Igor importer for phi files here: https://www.wavemetrics.com/project/phispefileloader

@lukaspie
Copy link
Collaborator Author

Closed as this will be addressed in the xps reader plugin: FAIRmat-NFDI/pynxtools-xps#5

@lukaspie lukaspie closed this Feb 21, 2024
@lukaspie lukaspie deleted the 224-xps-sub-reader-for-phi-versaprobe-data branch June 4, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sub-reader for PHI Versaprobe data
3 participants