Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update main, nexus, generate_eln READMEs #226

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Update main, nexus, generate_eln READMEs #226

merged 3 commits into from
Jan 31, 2024

Conversation

lukaspie
Copy link
Collaborator

  • Add documentation link to main readme
  • Add generate_eln tool to main readme
  • Typo fixes
  • use correct cli function in generate_eln readme

@coveralls
Copy link

coveralls commented Jan 31, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7728584681

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 44.584%
Totals Coverage Status
Change from base Build 7632295519: 0.0%
Covered Lines: 4906
Relevant Lines: 11004
💛 - Coveralls

sherjeelshabih
sherjeelshabih previously requested changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@sherjeelshabih sherjeelshabih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix. It looks good to me. I just have one change request. Let me know what you think.

pynxtools/eln_mapper/README.md Outdated Show resolved Hide resolved
domna
domna reviewed Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@domna domna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this. I would use the generate_eln help output and just copy this but apart from this it's fine.

pynxtools/eln_mapper/README.md Outdated Show resolved Hide resolved
domna
domna approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@domna domna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lukaspie lukaspie dismissed sherjeelshabih’s stale review January 31, 2024 16:06

It was fixed with the latest commit.

@lukaspie lukaspie merged commit d35df8d into master Jan 31, 2024
6 checks passed
@lukaspie lukaspie deleted the readme-updates branch January 31, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domna domna domna approved these changes

@sherjeelshabih sherjeelshabih sherjeelshabih left review comments

@RubelMozumder RubelMozumder Awaiting requested review from RubelMozumder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukaspie @coveralls @domna @sherjeelshabih