Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds XPS example files and completes tutorial docs #216

Merged
merged 5 commits into from
Jan 23, 2024
Merged

Adds XPS example files and completes tutorial docs #216

merged 5 commits into from
Jan 23, 2024

Conversation

sherjeelshabih
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Jan 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7625002207

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 44.584%
Files with Coverage Reduction New Missed Lines %
tests/dataconverter/test_writer.py 1 96.77%
Totals Coverage Status
Change from base Build 7614285402: 0.0%
Covered Lines: 4906
Relevant Lines: 11004
💛 - Coveralls

lukaspie
lukaspie approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@lukaspie lukaspie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM expect for one small comment

docs/tutorial/converting-data-to-nexus.md
2. Install [pynxtools](https://github.com/FAIRmat-NFDI/pynxtools/tree/master?tab=readme-ov-file#installation)
3. Verify you can run the ```dataconverter``` in a terminal window. Open a terminal with the Python environment where you installed ```pynxtools```. Then type the following:
1. Download the example files from here: [Example files](https://download-directory.github.io/?url=https%3A%2F%2Fgithub.com%2FFAIRmat-NFDI%2Fpynxtools%2Ftree%2Fdocumentation%2Fexamples%2Fxps)
2. **Extract** the zip and copy the files in your current working directory. You can find the working directory by typing the following in your terminal:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add how to extract the files from the zip from the console.

@sherjeelshabih sherjeelshabih merged commit 7221871 into master Jan 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaspie lukaspie lukaspie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sherjeelshabih @coveralls @lukaspie @domna