Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nomad Hotfix NeXus parsing #215

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Nomad Hotfix NeXus parsing #215

merged 1 commit into from
Jan 23, 2024

Conversation

domna
Copy link
Collaborator

@domna domna commented Jan 22, 2024

There is an error in nomad, which is probably due to the metainfo refactoring which runs into a keyerror. This fixes it.

We should go through the nomad metainfo and fix everything after the workshop. There are a lot of warnings and errors.

@domna domna requested a review from sherjeelshabih January 22, 2024 18:16
@coveralls
Copy link

coveralls commented Jan 22, 2024

Pull Request Test Coverage Report for Build 7615573750

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 44.584%

Files with Coverage Reduction New Missed Lines %
tests/dataconverter/test_writer.py 1 96.77%
Totals Coverage Status
Change from base Build 7614285402: 0.0%
Covered Lines: 4906
Relevant Lines: 11004

💛 - Coveralls

@domna domna merged commit 23ebe6e into master Jan 23, 2024
6 checks passed
@domna domna deleted the nomad-hotfix branch January 23, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants