-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow loading of plugins via entry_points #185
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7021204778
💛 - Coveralls |
This works really nicely. I have tested the stm reader and it gets loaded correctly. As we discussed, the next thing would be to have a testing strategy. Also, we will need a list of reader plugins in this repo to help users find them. |
We could build a cookiecutter template to get people started with developing their own readers |
sherjeelshabih
approved these changes
Nov 28, 2023
domna
changed the title
Allow loading of plugins via entry_points plugins
Allow loading of plugins via entry_points
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reader can basically refactored out as is, we just have to add a
pyproject.toml
with the following entrypoint specification:where
test
is the name of the reader referred by--reader
andMyReaderClass
is the reader class in the file.A working example can be found in https://github.com/FAIRmat-NFDI/pynxtools-stm for the sts/stm reader.