Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mpes data indices #178

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Fix mpes data indices #178

merged 1 commit into from
Nov 21, 2023
+1 −15

Conversation

domna
Copy link
Collaborator

@domna domna commented Nov 19, 2023

The data indices in NXdata should be int and not char. This fixes it.

@domna domna requested review from Arora0 and rettigl November 19, 2023 08:18
@coveralls
Copy link

coveralls commented Nov 19, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6919318427

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 51.59%
Totals Coverage Status
Change from base Build 6734085629: 0.001%
Covered Lines: 6166
Relevant Lines: 11952
💛 - Coveralls

@domna domna merged commit d904c8d into master Nov 21, 2023
4 checks passed
@domna domna deleted the fix-mpes-data-indices branch November 21, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arora0 Arora0 Arora0 approved these changes

@rettigl rettigl Awaiting requested review from rettigl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@domna @coveralls @Arora0