Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update definitions #153

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Update definitions #153

merged 3 commits into from
Sep 5, 2023

Conversation

domna
Copy link
Collaborator

@domna domna commented Sep 5, 2023

This updates the definitions and restores working base classes for mpes

@domna domna requested a review from sanbrock September 5, 2023 09:18
sanbrock
sanbrock approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@sanbrock sanbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Pull Request Test Coverage Report for Build 6085253595

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 51.053%
Files with Coverage Reduction New Missed Lines %
pynxtools/dataconverter/readers/shared/map_concepts/mapping_functors.py 1 11.86%
pynxtools/nyaml2nxdl/nyaml2nxdl_forward_tools.py 1 79.42%
pynxtools/nexus/nxdl_utils.py 2 74.79%
Totals Coverage Status
Change from base Build 6039906593: -0.02%
Covered Lines: 5985
Relevant Lines: 11723
💛 - Coveralls

@domna domna merged commit a6a6247 into master Sep 5, 2023
@domna domna deleted the update-defs-readd-mpes-bc branch September 5, 2023 13:33
mkuehbach pushed a commit that referenced this pull request Sep 5, 2023
@domna
Update definitions (#153)
6f6eed4 
* Update definitions

* Update regression tests

* Fix linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanbrock sanbrock sanbrock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domna @sanbrock