get units from h5 file first #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domna
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Looks good, some small comments:
- I think the error message is already included in the trace when you raise
... from exc. So it might be confusing when it is included in the latest error message - I think it's better to use if clauses instead of the try... except blocks as they are typically better to understand when reading the code (but I will refactor the reader a bit anyways when I add igor support and use the multi format reader).
Nothing of this is blocking the merge, so it is approved.
rettigl
force-pushed
the
read_units_from_h5
branch
from
45d9e53 to
67ee34d
Compare
rettigl
force-pushed
the
read_units_from_h5
branch
from
67ee34d to
f7464e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First try to get units from h5 file, if that fails use DEFAULT_UNITS
Includes also some code reorganization
closes #3