-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring in NOMAD examples #32
Conversation
lukaspie
commented
Oct 11, 2024
•
edited
Loading
edited
- NOMAD entry point for MPES example
- NOMAD integration test
- bring in example data
- update docs and README
60b2440
to
64931d1
Compare
33c6043
to
a548757
Compare
install uv in test
9a0161c
to
373edb6
Compare
@rettigl this should be ready. The tests are failing here because they don't install the specific pynxtools branch. But as you can see in FAIRmat-NFDI/pynxtools#448, the plugin tests work. So we can just merge that one first and re-run the tests here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The structure looks okay, but the actual example data don't seem to be the correct ones. Please take this as source:
https://gitlab.mpcdf.mpg.de/nomad-lab/north/mpes/-/tree/main/example?ref_type=heads
I will test again if that works with most recent everything.
For future compatibility, please add a version limit to sed-processor <1.0.0, as we want to release some breaking changes with v1 there soon, which will require a new config format.
What the tests do I don't really understand.
6042c15
to
7cdfbf7
Compare
I added it. Also, in E1, we are downloading the example data again with curl? Is this intentional (i.e., when not used in nomad directly)? If so, we should re-add it in E4 as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems okay now.