Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test data to new NXmpes #24

Merged
merged 6 commits into from
Jul 17, 2024
Merged

Update test data to new NXmpes #24

merged 6 commits into from
Jul 17, 2024

Conversation

lukaspie
Copy link
Contributor

Reflects changes from FAIRmat-NFDI/nexus_definitions#266

@lukaspie lukaspie force-pushed the update-to-new-nxmpes branch from 0fdffb9 to 2b9f637 Compare July 12, 2024 09:40
@lukaspie lukaspie requested a review from domna July 12, 2024 13:28
@domna
Copy link
Collaborator

domna commented Jul 16, 2024

This works properly with this branch FAIRmat-NFDI/pynxtools#379 for me.

I added an additional commit to remove the definition/@version from the config file. It should write the repo version of the nexus_definitions there automatically instead of None.

@lukaspie lukaspie merged commit c771ec9 into main Jul 17, 2024
6 checks passed
@lukaspie lukaspie deleted the update-to-new-nxmpes branch July 17, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants