Add scatter plot #37
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # how to add a new ion to the database | ||
|
|
||
| !!! note "Attention" | ||
| TODO |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # How to create a perovskite composition | ||
|
|
||
| A standarized perovskite composition entry can be created using the ions database. | ||
| To create one you would need to follow the steps below in which we will create a Cs<sub>0.05</sub>FA<sub>0.76</sub>MA<sub>0.16</sub>PbBr<sub>1.5</sub>I<sub>1.5</sub> | ||
| composition entry: | ||
|
|
||
| <iframe src="https://scribehow.com/embed/How_to_Create_a_New_Perovskite_Composition_Upload__HdNr9pn5S_2jFM5Ii4FYkA?removeLogo=true" width="100%" height="640" allowfullscreen frameborder="0"></iframe> | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # how to add a new ion to the database | ||
|
|
||
| !!! note "Attention" | ||
| TODO |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| # Install This Plugin | ||
|
|
||
| This plugin can be installed in an exiting NOMAD Oasis installation by following | ||
| the steps described in the [NOMAD documentation](https://nomad-lab.eu/prod/v1/staging/docs/howto/oasis/plugins_install.html). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # how to add a new ion to the database | ||
|
|
||
| !!! note "Attention" | ||
| TODO |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # Sharing a perovskite composition in NOMAD | ||
|
|
||
| !!! note "Attention" | ||
| TODO |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,25 @@ | ||
| site_name: nomad-perovskite-solar-cells-database | ||
| site_description: This is a NOMAD plugin for the perovskite solar cells database. | ||
| edit_uri: "" | ||
| repo_url: https://github.com/FAIRmat-NFDI/nomad-perovskite-solar-cells-database | ||
|
|
||
| nav: | ||
| - Home: index.md | ||
| - Tutorial: tutorial/tutorial.md | ||
| - How-to guides: | ||
| - Install this plugin: how_to/install_this_plugin.md | ||
| - Contribute to this plugin: how_to/contribute_to_this_plugin.md | ||
| - Contribute to the documentation: how_to/contribute_to_the_documentation.md | ||
| - Search for ions: how_to/search_for_ions.md | ||
| - Add a new ion: how_to/add_a_new_ion.md | ||
| - Export a cation structure: how_to/export_a_cation_structure.md | ||
| - Create a perovskite compostion: how_to/create_a_perovskite_composition.md | ||
| - Explanation: explanation/explanation.md | ||
| - Reference: reference/references.md | ||
| plugins: | ||
| - search | ||
| - glightbox | ||
|
|
||
| theme: | ||
| name: material | ||
| palette: | ||
|
|
@@ -26,7 +30,11 @@ theme: | |
| logo: assets/nomad-plugin-logo.png | ||
| favicon: assets/favicon.png | ||
| features: | ||
| - navigation.path | ||
| - navigation.footer | ||
| - navigation.top | ||
| icon: | ||
| repo: fontawesome/brands/github | ||
| custom_dir: docs/theme | ||
| markdown_extensions: | ||
| - attr_list | ||
|
|
@@ -37,17 +45,16 @@ markdown_extensions: | |
| anchor_linenums: true | ||
| - pymdownx.inlinehilite | ||
| - pymdownx.snippets | ||
| - mkdocs-click | ||
| - pymdownx.extra | ||
| - toc: | ||
| permalink: True | ||
| - pymdownx.arithmatex: | ||
| generic: true | ||
|
|
||
| extra: | ||
| generator: false | ||
| homepage: https://github.com/FAIRmat-NFDI/nomad-perovskite-solar-cells-database | ||
| use_directory_urls: false | ||
| extra_css: | ||
| - stylesheets/extra.css | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -69,15 +69,93 @@ | |
| yaml.safe_load( | ||
| """ | ||
| widgets: | ||
| - type: periodictable | ||
|
There was a problem hiding this comment. issue (complexity): Consider using YAML anchors and aliases to define reusable layout configurations. The layout configuration can be simplified using YAML anchors and aliases to reduce repetition while maintaining the same functionality. Here's how: widgets:
- type: periodictable
scale: linear
search_quantity: results.material.elements
layout:
# Define base layout template
&base_layout
minH: 8
minW: 12
y: 0
x: 0
xxl:
<<: *base_layout
h: 9
w: 13
xl:
<<: *base_layout
h: 9
w: 12
lg: &standard_size
<<: *base_layout
h: 8
w: 12
md:
<<: *standard_size
sm:
<<: *standard_sizeThis approach:
The same pattern can be applied to the scatter_plot widget's layout. |
||
| scale: linear | ||
| search_quantity: results.material.elements | ||
| layout: | ||
| xxl: | ||
| minH: 8 | ||
| minW: 12 | ||
| h: 9 | ||
| w: 13 | ||
| y: 0 | ||
| x: 0 | ||
| xl: | ||
| minH: 8 | ||
| minW: 12 | ||
| h: 9 | ||
| w: 12 | ||
| y: 0 | ||
| x: 0 | ||
| lg: | ||
| minH: 8 | ||
| minW: 12 | ||
| h: 8 | ||
| w: 12 | ||
| y: 0 | ||
| x: 0 | ||
| md: | ||
| minH: 8 | ||
| minW: 12 | ||
| h: 8 | ||
| w: 12 | ||
| y: 0 | ||
| x: 0 | ||
| sm: | ||
| minH: 8 | ||
| minW: 12 | ||
| h: 8 | ||
| w: 12 | ||
| y: 0 | ||
| x: 0 | ||
| - type: scatter_plot | ||
| autorange: true | ||
| size: 1000 | ||
| markers: | ||
| color: | ||
| search_quantity: results.material.topology[0].structural_type | ||
| y: | ||
| search_quantity: data.pure_substance.molar_mass#perovskite_solar_cell_database.composition.PerovskiteAIon | ||
| title: A cation molar mass | ||
| x: | ||
| search_quantity: results.material.topology[0].n_atoms | ||
| title: "" | ||
| layout: | ||
| xxl: | ||
| minH: 3 | ||
| minW: 3 | ||
| h: 6 | ||
| w: 9 | ||
| y: 0 | ||
| x: .inf | ||
|
There was a problem hiding this comment. issue (bug_risk): Invalid x coordinate value '.inf' in xxl layout The x coordinate value '.inf' is invalid and could cause rendering issues. Please specify a valid numeric value. |
||
| xl: | ||
| minH: 3 | ||
| minW: 3 | ||
| h: 9 | ||
| w: 18 | ||
| y: 0 | ||
| x: 12 | ||
| lg: | ||
| minH: 3 | ||
| minW: 3 | ||
| h: 8 | ||
| w: 12 | ||
| y: 0 | ||
| x: 12 | ||
| md: | ||
| minH: 3 | ||
| minW: 3 | ||
| h: 8 | ||
| w: 6 | ||
| y: 0 | ||
| x: 12 | ||
| sm: | ||
| minH: 3 | ||
| minW: 3 | ||
| h: 6 | ||
| w: 9 | ||
| y: 8 | ||
| x: 0 | ||
| """ | ||
| ) | ||
| ), | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| def test_importing_app(): | ||
| # This will raise an exception if pydantic model validation fails for the app | ||
| from perovskite_solar_cell_database.apps.solar_cell_app import ( # type: ignore | ||
| solar_cell_app, # noqa: F401 | ||
|
Comment on lines
+3
to
4
There was a problem hiding this comment. issue (testing): Missing tests for the new scatter plot functionality The PR adds a new scatter plot widget but there are no tests to verify its configuration and behavior. Consider adding tests that verify:
|
||
| ) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (typo): Fix typo: 'standarized' should be 'standardized'