Skip to content

Commit

Permalink
Refactor inheritance for Synthesis and SynthesisStep
Browse files Browse the repository at this point in the history
  • Loading branch information
fabianschoeppach committed Nov 7, 2024
1 parent f025c6c commit 5f90559
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions src/perovskite_tandem_database/schema_packages/tandem.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
ActivityStep,
ElementalComposition,
Process,
ProcessStep,
)
from nomad.metainfo import Quantity, Section, SubSection
from nomad.metainfo.data_type import Enum
Expand Down Expand Up @@ -189,7 +190,7 @@ class Storage(ArchiveSection):
)


class SynthesisStep(Activity, ArchiveSection):
class SynthesisStep(ProcessStep):
"""
A section describing a general synthesis step.
More specific synthesis steps are inherited from this class.
Expand Down Expand Up @@ -251,15 +252,15 @@ class SynthesisStep(Activity, ArchiveSection):
)


class CleaningStep(ActivityStep):
class CleaningStep(ProcessStep):
"""
A cleaning procedure step.
"""

pass


class Cleaning(Activity):
class Cleaning(Process):
"""
A section describing a cleaning procedure. Typically before a subsequent synthesis step.
"""
Expand Down Expand Up @@ -333,7 +334,7 @@ class GasPhaseSynthesis(SynthesisStep):
)


class Synthesis(Process, ArchiveSection):
class Synthesis(Process):
steps = SubSection(section_def=SynthesisStep, repeats=True)


Expand Down

0 comments on commit 5f90559

Please sign in to comment.