-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
10 replace xrd file reader #13
base: main
Are you sure you want to change the base?
Conversation
RubelMozumder
commented
Sep 18, 2023
•
edited
Loading
edited
- Adding pynxtools as a submodule
- Get the entire plugin workflow working
- Running
- Write a general parser for
- xrdml
- xye
- udf
- raw
- General normalizer to fill NeXus template from file parsers (inside reader)
- Set a pipeline for getting NeXus template in plugin schema
- Test Plugin in Nomad
- Add a normalize step in the plugin to fill up the NeXus section in Nomad.
15fd406
to
28fb1ef
Compare
Hi @hampusnasstrom, once I am done with the ci in pynxtools and nomad then I would urge to test the plugin in nomad and give a feedback. Other are, the different types of files:
|
Sarthak and I are currently implementing .xrdml (without xrayutilities) and .rasx in a standalone reader for now. We will then have a look at other file types as we get requests from users. I will later suggest some changes in your code after we have done some refactoring. We discussed in area A and think it best to extract the read and write into functions like Markus is suggesting here: https://gitlab.mpcdf.mpg.de/nomad-lab/nomad-FAIR/-/blob/develop/docs/explanation/processing.md?ref_type=heads#strategies-for-re-usable-processing-code |