Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

58 substrate improvements #75

Closed
wants to merge 30 commits into from
Closed

58 substrate improvements #75

wants to merge 30 commits into from

Conversation

aalbino2
Copy link
Collaborator

@aalbino2 aalbino2 commented Sep 2, 2024

@ndaelman-hu could you check if the HKL defs are okay please?

@aalbino2 aalbino2 linked an issue Sep 2, 2024 that may be closed by this pull request
2 tasks
@aalbino2
Copy link
Collaborator Author

aalbino2 commented Sep 2, 2024

ah it's very hard to review this because I branched from anothe rfeature branch

check the class

@hampusnasstrom
Copy link
Collaborator

But we can't merge this into main before the feature branch is merged, right?

@aalbino2
Copy link
Collaborator Author

aalbino2 commented Sep 2, 2024

indeed, but what are we waiting for to merge that?

@hampusnasstrom
Copy link
Collaborator

Nothing I guess, I'm working on getting the nomad-measurements ready.

@aalbino2 aalbino2 closed this Sep 2, 2024
@aalbino2 aalbino2 deleted the 58-substrate-improvements branch September 2, 2024 11:25
@aalbino2
Copy link
Collaborator Author

aalbino2 commented Sep 2, 2024

I deleted the branch because it was a nightmare to rebase in main due to conflicts. I'll open a new PR

Copy link

@ndaelman-hu ndaelman-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depending on what you exactly want to express, you'll have to modify the definitions for the Miller indices.

I only took a look at the quantity definitions. Let me know if there's also any normalization that I have to review.

src/nomad_material_processing/general.py Show resolved Hide resolved
src/nomad_material_processing/general.py Show resolved Hide resolved
src/nomad_material_processing/general.py Show resolved Hide resolved
src/nomad_material_processing/general.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Substrate improvements
5 participants