-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
58 substrate improvements #75
Conversation
Co-authored-by: Sarthak Kapoor <[email protected]>
…calVaporDeposition
Co-authored-by: Hampus Näsström <[email protected]>
ah it's very hard to review this because I branched from anothe rfeature branch check the class
|
But we can't merge this into main before the feature branch is merged, right? |
indeed, but what are we waiting for to merge that? |
Nothing I guess, I'm working on getting the nomad-measurements ready. |
I deleted the branch because it was a nightmare to rebase in main due to conflicts. I'll open a new PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depending on what you exactly want to express, you'll have to modify the definitions for the Miller indices.
I only took a look at the quantity definitions. Let me know if there's also any normalization that I have to review.
@ndaelman-hu could you check if the HKL defs are okay please?