Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor plugin structure #69

Merged
merged 29 commits into from
Sep 2, 2024
Merged

refactor plugin structure #69

merged 29 commits into from
Sep 2, 2024

Conversation

aalbino2
Copy link
Collaborator

points to check:

  • does the vapor_deposition need an entry point for its general? The entry point does not affect the use of those classes, because there are no EntryData in there

@aalbino2 aalbino2 linked an issue Aug 21, 2024 that may be closed by this pull request
Update to new plugin mechanism #41
Closed
@aalbino2 aalbino2 self-assigned this Aug 21, 2024
@aalbino2 aalbino2 added this to the Version 1.0.0 milestone Aug 21, 2024
@aalbino2
Copy link
Collaborator Author

aalbino2 commented Aug 22, 2024 •
edited
Loading

I'm making some small improvements to quantites based on last chat with Oliver. I think it is fine to include it here for a more agile integration in the code

ka-sarthak
ka-sarthak approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@ka-sarthak ka-sarthak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I suggested a small change in the description of Solution entry point. Quite optional.

The formatted code looks so pretty!

A side remark: with these changes, we will have the general keyword in all the import paths. Would be nicer if that's not the case.

src/nomad_material_processing/solution/__init__.py Outdated Show resolved Hide resolved
@hampusnasstrom hampusnasstrom linked an issue Aug 23, 2024 that may be closed by this pull request
Ruff formatting #68
Closed
@aalbino2 aalbino2 merged commit 9eb83aa into main Sep 2, 2024
5 checks passed
@ka-sarthak ka-sarthak deleted the 41-update-to-new-plugin-mechanism branch September 2, 2024 13:56
aalbino2 added a commit that referenced this pull request Sep 10, 2024
@aalbino2 @ka-sarthak
@markus1978 @hampusnasstrom
refactor plugin structure (#69)
48a0f82 
* refactored structure

* updated toml file and relaunched ruff linting

* further lintage activities

* fixed ruff formatting and test files

* reverted nomad-lab version in toml

* added aliases and updated README

* extended conductivity-type quantity

* added carrier density deviation quantity

* harmonized type=float everywhere

* remove unused import

* filled default values in special Geometry shapes

* Bump up nomad-lab to 1.3.4dev

* fixed reference to substrate holder

* InsertReduction class refinements

* fixed InsertReduction reference

* refined recipe classes

* refined recipe classes

* added starting and ending T in annealing step

* Update src/nomad_material_processing/solution/__init__.py

Co-authored-by: Sarthak Kapoor <[email protected]>

* reformatting

* check if aliases work

* reverted m_def to old paths in test files

* reverted solution m_def

* reverted nomad_material_processing.vapor_deposition.pvd.general.PhysicalVaporDeposition

* added print statement in tests

* added print statement in tests

* Explicitely load metainfo before tests. (#72)

Co-authored-by: Hampus Näsström <[email protected]>

* remove unused import

* formatting

---------

Co-authored-by: Sarthak Kapoor <[email protected]>
Co-authored-by: Sarthak Kapoor <[email protected]>
Co-authored-by: Markus Scheidgen <[email protected]>
Co-authored-by: Hampus Näsström <[email protected]>
hampusnasstrom added a commit that referenced this pull request Sep 18, 2024
@budschi @aalbino2
@ka-sarthak @markus1978 @hampusnasstrom
48 documentation of the plugin (#78)
88fe014 
* add doc structure from nomad measurements

* update docs analog to Measurements

* small fixes on index.md

* update install.md

* update contribute to plugin docs

* update contact.md

* add tutorials to docs

* data model docs

* refactor plugin structure (#69)

* refactored structure

* updated toml file and relaunched ruff linting

* further lintage activities

* fixed ruff formatting and test files

* reverted nomad-lab version in toml

* added aliases and updated README

* extended conductivity-type quantity

* added carrier density deviation quantity

* harmonized type=float everywhere

* remove unused import

* filled default values in special Geometry shapes

* Bump up nomad-lab to 1.3.4dev

* fixed reference to substrate holder

* InsertReduction class refinements

* fixed InsertReduction reference

* refined recipe classes

* refined recipe classes

* added starting and ending T in annealing step

* Update src/nomad_material_processing/solution/__init__.py

Co-authored-by: Sarthak Kapoor <[email protected]>

* reformatting

* check if aliases work

* reverted m_def to old paths in test files

* reverted solution m_def

* reverted nomad_material_processing.vapor_deposition.pvd.general.PhysicalVaporDeposition

* added print statement in tests

* added print statement in tests

* Explicitely load metainfo before tests. (#72)

Co-authored-by: Hampus Näsström <[email protected]>

* remove unused import

* formatting

---------

Co-authored-by: Sarthak Kapoor <[email protected]>
Co-authored-by: Sarthak Kapoor <[email protected]>
Co-authored-by: Markus Scheidgen <[email protected]>
Co-authored-by: Hampus Näsström <[email protected]>

* added todo

* level of schema docs

* description module by module

* add text to "how-to-use"

* moved schemas_and_readers to data_model

* add text to references

* added nomad_material_processing.vapor_deposition.general

* fix typos in develop.md

* delete old text blocks from develop.md

* fix small errors in install.md

* Bugfix: rename in mkdocs.yml

* Add explanation for solution schema

* added CVD

* modify refernces

* add doc structure from nomad measurements

* update docs analog to Measurements

* small fixes on index.md

* update install.md

* update contribute to plugin docs

* update contact.md

* add tutorials to docs

* data model docs

* added todo

* level of schema docs

* description module by module

* add text to "how-to-use"

* moved schemas_and_readers to data_model

* add text to references

* added nomad_material_processing.vapor_deposition.general

* fix typos in develop.md

* delete old text blocks from develop.md

* fix small errors in install.md

* Bugfix: rename in mkdocs.yml

* Add explanation for solution schema

* added CVD

* modify refernces

* Refactor heading level; rename to schemas.md

* added CVD and MOVPE

* Add explanation for solution preparation

* Add use this plugin - built in schema

* started YAML customization how to

* Fix in the ref

* added yaml example

* Changed section titles in schemas.md

* Added basic explanation of PVD schemas

* Added how to use this plugin in another python schema plugin

* add small fixes to docs

* cleaned glossary

* add link to NOMAD glossary in references

* small fixes in index and references

* refinements of schemas and linking of glossary

* Add setup dev env, links, fix typos, revise contact

* Small language fixes

---------

Co-authored-by: Andrea Albino <[email protected]>
Co-authored-by: Andrea Albino <[email protected]>
Co-authored-by: Sarthak Kapoor <[email protected]>
Co-authored-by: Sarthak Kapoor <[email protected]>
Co-authored-by: Markus Scheidgen <[email protected]>
Co-authored-by: Hampus Näsström <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ka-sarthak ka-sarthak ka-sarthak approved these changes

@hampusnasstrom hampusnasstrom Awaiting requested review from hampusnasstrom

Assignees

@aalbino2 aalbino2

Labels
None yet
Projects
None yet
Milestone
Version 1.0.0
Development

Successfully merging this pull request may close these issues.

Ruff formatting Update to new plugin mechanism
3 participants
@aalbino2 @ka-sarthak @markus1978