Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

started general module #66

Merged

Conversation

aalbino2
Copy link
Collaborator

No description provided.

@aalbino2 aalbino2 self-assigned this Aug 16, 2024
@aalbino2 aalbino2 linked an issue Aug 16, 2024 that may be closed by this pull request
Copy link
Collaborator

@hampusnasstrom hampusnasstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some comments.

src/nomad_material_processing/general/schema.py Outdated Show resolved Hide resolved
src/nomad_material_processing/general/schema.py Outdated Show resolved Hide resolved
src/nomad_material_processing/general/schema.py Outdated Show resolved Hide resolved
src/nomad_material_processing/general/schema.py Outdated Show resolved Hide resolved
src/nomad_material_processing/general/schema.py Outdated Show resolved Hide resolved
src/nomad_material_processing/general/schema.py Outdated Show resolved Hide resolved
src/nomad_material_processing/general/schema.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@hampusnasstrom hampusnasstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should use ProcessStep since we are inheriting from process.

src/nomad_material_processing/general/schema.py Outdated Show resolved Hide resolved
src/nomad_material_processing/general/schema.py Outdated Show resolved Hide resolved
src/nomad_material_processing/general/schema.py Outdated Show resolved Hide resolved
src/nomad_material_processing/general/schema.py Outdated Show resolved Hide resolved
src/nomad_material_processing/general/schema.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@hampusnasstrom hampusnasstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks :)

@aalbino2 aalbino2 merged commit 1c8280c into main Aug 19, 2024
3 of 5 checks passed
@aalbino2 aalbino2 deleted the 65-include-etching-annealing-cleaning-in-general-module branch August 19, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

include Etching, Annealing, Cleaning in general module
2 participants