Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SampleHolder small changes #117

Merged
merged 2 commits into from
Oct 31, 2024
Merged

SampleHolder small changes #117

merged 2 commits into from
Oct 31, 2024

Conversation

aalbino2
Copy link
Collaborator

Few things have been changed:

  • insert reduction wrapped with the usual EntityReference subclass
  • material -> holder_material
  • substrate_holder label
  • insert_reduction reference is now included in the FilledSubstrateHolder, as it is not usually lodged in an empty one

@aalbino2 aalbino2 self-assigned this Oct 28, 2024
@aalbino2 aalbino2 linked an issue Oct 28, 2024 that may be closed by this pull request
fixes for sample holder #116
Closed
hampusnasstrom
hampusnasstrom requested changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@hampusnasstrom hampusnasstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the name of the class

src/nomad_material_processing/vapor_deposition/general.py Outdated Show resolved Hide resolved
src/nomad_material_processing/vapor_deposition/general.py Outdated Show resolved Hide resolved
@aalbino2 @hampusnasstrom
Apply suggestions from code review
462f171 
Co-authored-by: Hampus Näsström <[email protected]>
@aalbino2
Copy link
Collaborator Author

aalbino2 commented Oct 31, 2024 •
edited
Loading

Looks good except for the name of the class

Definitely, it was an overlook from my side.

Thanks for quick review, i'm gonna merge it now

@aalbino2 aalbino2 merged commit 8c29984 into main Oct 31, 2024
5 checks passed
@aalbino2 aalbino2 deleted the 116-fixes-for-sample-holder branch October 31, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hampusnasstrom hampusnasstrom hampusnasstrom approved these changes

Assignees

@aalbino2 aalbino2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fixes for sample holder
2 participants
@aalbino2 @hampusnasstrom