-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add setup dev env, links, fix typos, revise contact
- Loading branch information
1 parent
3cdea31
commit e0698f5
Showing
5 changed files
with
42 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,7 @@ You can also send as directly an email to the main contributors list: | |
|------|------------|--------|-----------------| | ||
| Dr. Andrea Albino | [[email protected]](mailto:[email protected]) | CVD | [@aalbino2](https://github.com/aalbino2) | | ||
| Dr. Hampus Näsström | [[email protected]](mailto:[email protected]) | PVD | [@hampusnasstrom](https://github.com/hampusnasstrom) | | ||
| Sarthak Kapoor | [[email protected]](mailto:[email protected]) | Solutions | [@ka-sarthak](https://github.com/ka-sarthak) | | ||
| Sarthak Kapoor, MSc. | [[email protected]](mailto:[email protected]) | Solutions | [@ka-sarthak](https://github.com/ka-sarthak) | | ||
| Dr. José Marquez | [[email protected]](mailto:[email protected]) | General | [@Pepe-Marquez](https://github.com/Pepe-Marquez) | | ||
| Dr. Sebastian Brückner (**Coordinator**) | [[email protected]](mailto:[email protected]) | General | [@budschi](https://github.com/budschi) | | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,21 +4,45 @@ The **NOMAD-material-processing plugin** is a community-driven effort aimed at p | |
|
||
Here’s how you can contribute: | ||
|
||
## 1. Extract General Components from Your Custom Schema | ||
## 1. Setting up a development environment | ||
|
||
To make code contributions to this package, you need to setup a local development environment. It starts with | ||
[cloning](https://docs.github.com/en/repositories/creating-and-managing-repositories/cloning-a-repository) | ||
this repo in a local folder. | ||
Create a fresh Python environment and install the package in | ||
[editable](https://pip.pypa.io/en/stable/topics/local-project-installs/#editable-installs) | ||
mode (with `-e` flag) with its | ||
`dev` dependencies. `pytest` package is installed as a part of the `dev` dependencies. | ||
To run the tests locally, you can simply run `pytest` in the topmost folder of the repo. | ||
|
||
```sh | ||
git clone [email protected]:FAIRmat-NFDI/nomad-material-processing.git | ||
cd nomad-material-processing | ||
|
||
python3.11 -m venv .pyenv | ||
source .pyenv/bin/activate | ||
pip install -e .[dev] --index-url https://gitlab.mpcdf.mpg.de/api/v4/projects/2187/packages/pypi/simple | ||
pytest | ||
``` | ||
|
||
## 2. Extract General Components from Your Custom Schema | ||
|
||
If you have developed custom schemas for your own lab or project, consider extracting the generalizable aspects and contributing them to the community plugin. Look for data structures, methods, or components that are not specific to your setup but could benefit the wider community. By sharing these, you help build a richer, more comprehensive plugin that everyone can use. | ||
|
||
## 2. Test in Your Own Plugin | ||
## 3. Test in Your Own Plugin | ||
|
||
Before submitting contributions, it’s important to test your changes in your own NOMAD plugin environment. This ensures that your extracted schema or code functions as expected and aligns with the overall plugin structure. Testing locally also helps identify potential conflicts or improvements before making a broader contribution. | ||
|
||
## 3. Open an Issue | ||
## 4. Open an Issue | ||
|
||
If you have suggestions, questions, or encounter any issues while using or developing the plugin, feel free to open an issue on the plugin’s GitHub repository. This helps maintainers and other contributors track potential improvements or areas of concern. Be as detailed as possible, providing relevant context and, if applicable, examples of the issue you're encountering. | ||
|
||
## 4. Create a Pull Request | ||
## 5. Create a Pull Request | ||
|
||
Once you’ve tested your contribution and are confident it benefits the community, create a pull request (PR). In your PR, clearly describe what changes you are proposing and why they are necessary. If you’re contributing general components extracted from your custom schema, explain how they can be applied broadly across different use cases. Be sure to follow the repository's contribution guidelines and reference any related issues if applicable. | ||
Once you’ve tested your contribution and are confident it benefits the community, create a | ||
[pull request](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests) | ||
(PR). | ||
In your PR, clearly describe what changes you are proposing and why they are necessary. If you’re contributing general components extracted from your custom schema, explain how they can be applied broadly across different use cases. Be sure to follow the repository's contribution guidelines and reference any related issues if applicable. | ||
|
||
By contributing to this plugin, you are helping build a more cohesive and interoperable materials science data ecosystem. We appreciate your input and collaboration! | ||
|