This repository has been archived by the owner on Dec 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Added Equation
and MathML
datatype
#48
Open
JR-1991
wants to merge
16
commits into
main
Choose a base branch
from
equation-type
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haeussma
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the new types and methods on an existing data model. Works as expected.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds two new math types to handle and evaluate equations. The first type is called
Equation
, representing equations as strings. It then converts them tosympy
expressions and extracts all symbols. The second type is theMathML
implementation, which works similarly toEquation
but serializes to MathML. However, theMathML
implementation cannot be serialized into JSON due to its structure since the operations are empty elements that are not supported in JSON.Examples
To use the new datatypes, the following markdown demonstrates the necessary type names:
Both types are used in the same way, yet differ in their respective output. Here is a demonstration how both can be used and serialized:
Equation Type
MathML Type
Important
The resulting XML tree will always use the
math
tag, no matter what the attribute name is. This is necessary to comply to the MathML schema.Evaluation
Both data types evaluate upon being called and can thus be used for calculations. This can be done in the following way: