Fixed CreatePart and Clone failing to work under Content Streaming #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using tags, we can wait for the parts to replicate in. Right now, F3X falters at creating/cloning parts with content streaming. This is because the code assumes that the instances will instantly replicate, which is no longer true with content streaming. Hence, the list of parts the client receives from the server becomes empty, despite being created on the server. So, from the server, we give the client a tag to listen to for the newly made parts. Most times, it shouldn't need to wait for the parts to come. But, with enough parts being cloned, it may need to wait for several chunks. However, sometimes the parts will never stream in if far enough, so simply best to give up after a reasonable amount of time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using tags, we can wait for the parts to replicate in. Right now, F3X falters at creating/cloning parts with content streaming. This is because the code assumes that the instances will instantly replicate, which is no longer true with content streaming. Hence, the list of parts the client receives from the server becomes empty, despite being created on the server.
So, from the server, we give the client a tag to listen to for the newly made parts. Most times, it shouldn't need to wait for the parts to come. But, with enough parts being cloned, it may need to wait for several chunks. However, sometimes the parts will never stream in if far enough, so simply best to give up after a reasonable amount of time.