Skip to content

Commit

Permalink
fix: 0 displayed instead of nothing if there is no textTracks
Browse files Browse the repository at this point in the history
  • Loading branch information
bwallberg committed Dec 21, 2023
1 parent 8ca0952 commit b3ec497
Show file tree
Hide file tree
Showing 10 changed files with 4,684 additions and 3,317 deletions.
7,983 changes: 4,675 additions & 3,308 deletions package-lock.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"jest-environment-jsdom": "^28.1.3",
"lerna": "^3.22.1",
"microbundle": "^0.12.4",
"parcel": "^2.3.2",
"parcel": "^2.10.3",
"prettier": "^2.1.1",
"sass": "^1.26.10",
"typescript": "^4.0.2"
Expand Down
2 changes: 1 addition & 1 deletion packages/airplay/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/cast/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/core/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/demo/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/eyevinn-skin/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/eyevinn-skin/src/EyevinnSkin.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ export default function EyevinnSkin({
<div class={style.divider} />
<CastButton />
{airplayAvailable && <AirPlayButton onClick={toggleAirPlay} />}
{state?.isCasting === false && state?.textTracks.length && (
{state?.isCasting === false && !!state?.textTracks.length && (
<TextTrackButton
textTracks={state?.textTracks}
onChange={changeTextTrack}
Expand Down
2 changes: 1 addition & 1 deletion packages/player/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/web-player-component/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit b3ec497

Please sign in to comment.