Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace testing content #87

Merged
merged 1 commit into from
Nov 12, 2024
Merged

feat: replace testing content #87

merged 1 commit into from
Nov 12, 2024

Conversation

Wkkkkk
Copy link
Contributor

@Wkkkkk Wkkkkk commented Nov 12, 2024 •
edited
Loading

This commit replaced some testing creatives.
The previous ones are valid MP4 files but AVPlayer does not accept MP4 files whose mdat box precedes moov box. The new content has a structure like ftyp+moov+mdat.

birme
birme approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@birme birme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wkkkkk
Copy link
Contributor Author

Wkkkkk commented Nov 12, 2024

Merging is blocked because I'm not authorized.

@birme birme merged commit 93b2d76 into main Nov 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birme birme birme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wkkkkk @birme