Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiple VAST versions #79

Merged
merged 2 commits into from
Feb 1, 2024
Merged

feat: support multiple VAST versions #79

merged 2 commits into from
Feb 1, 2024

Conversation

oscnord
Copy link
Contributor

@oscnord oscnord commented Jan 31, 2024

This PR adds support for multiple VAST versions. Versions supported are 2, 3 and 4 where 4 is the default.

@oscnord oscnord marked this pull request as ready for review January 31, 2024 15:09
@oscnord oscnord requested a review from Nfrederiksen January 31, 2024 15:09
@oscnord oscnord self-assigned this Jan 31, 2024
@oscnord oscnord linked an issue Jan 31, 2024 that may be closed by this pull request
@oscnord oscnord requested a review from birme January 31, 2024 15:23
utils/vast-maker.js Outdated Show resolved Hide resolved
utils/vast-maker.js Outdated Show resolved Hide resolved
@oscnord oscnord requested a review from Nfrederiksen January 31, 2024 15:56
Copy link
Collaborator

@Nfrederiksen Nfrederiksen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM sir

@oscnord
Copy link
Contributor Author

oscnord commented Feb 1, 2024

@Nfrederiksen @birme Looks like I don't have access to merge the PR so feel free to do it whenever you feel like it.

@birme birme merged commit ac509ad into main Feb 1, 2024
2 checks passed
@birme birme deleted the feat/78 branch February 1, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request for Test Ad Server to Support Multiple VAST Versions
3 participants