[CP Stag] Fix: Reports - "Customize your search" tooltip reappears while creating an expense #54897

rayane-djouah · 2025-01-07T18:49:41Z

Explanation of Change

Fixed Issues

$ #54879
PROPOSAL:

Tests

Open the Expensify app.
Log in with a new account.
Tap on "Reports"
Tap on the FAB and select "Create Expense"
Start the expense creation process.
Check the "Customize your search" tooltip behaviour during the process.
Expected Result: "Customize your search" tooltip, shouldn´t be displayed while creating an expense.

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-07.at.11.54.58.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-01-07.at.11.46.21.PM.mov

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-07.at.23.38.47.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-07.at.23.41.33.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-01-07.at.11.01.59.PM.mov

MacOS: Desktop

Screen.Recording.2025-01-07.at.11.33.13.PM.mov

…ng an expense

melvin-bot · 2025-01-07T19:06:40Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-01-07T19:11:13Z

🚧 @puneetlath has triggered a test build. You can view the workflow run here.

github-actions · 2025-01-07T19:35:48Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/54897/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/54897/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/54897/NewExpensify.dmg	https://54897.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

src/pages/Search/SearchTypeMenuNarrow.tsx

…ng-an-expense

…ch page

rayane-djouah · 2025-01-07T22:59:18Z

bug: https://expensify.slack.com/archives/C01GTK53T8Q/p1736285136997179?thread_ts=1736265399.917209&cid=C01GTK53T8Q

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-07.at.21.51.57.mp4

fixed in d8171c4

rayane-djouah · 2025-01-07T23:02:14Z

@ikevin127, please make sure to test the steps from this PR, in addition to the blocker steps and the steps for this bug.

ikevin127 · 2025-01-07T23:05:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android-mweb.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios-mweb.mp4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

ikevin127

Tests from PR #54710:

Concierge Chat Tooltip ✅
FAB (Floating Action Button) Tooltip ✅
QAB (Quick Action Button) Tooltip ✅
Workspace Chat Tooltip ✅
Filter Button Tooltip ✅
Inbox Icon Tooltip ✅
"+" Button Tooltip in Invited Workspace ✅
For all other tooltips ✅

Saved search tooltip ⚠️ (only showing the tooltip on large layout devices LNH, not showing in narrow layout devices)

Wide	Narrow

I've been told that this is expected though.

✅ This issue is also not reproducible anymore on this PR (fixed).

thienlnam · 2025-01-08T00:13:19Z

Taking over review as this is a deploy blocker and urgent

thienlnam · 2025-01-08T00:15:20Z

Had to delete Ishpaul's checklist since the PR Reviewer checklist won't work if the first one is incomplete

OSBotify · 2025-01-08T00:24:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…ile-creating-an-expense [CP Stag] Fix: Reports - "Customize your search" tooltip reappears while creating an expense (cherry picked from commit 56444a5) (CP triggered by thienlnam)

github-actions · 2025-01-08T01:00:30Z

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 9.0.81-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2025-01-08T02:45:52Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.81-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

rayane-djouah added 4 commits January 7, 2025 19:48

Fix: Reports - "Customize your search" tooltip reappears while creati…

0d263c3

…ng an expense

Clean up navigation listener

0a7f69c

reorder

fecf2a1

Refactor

9446444

rayane-djouah marked this pull request as ready for review January 7, 2025 19:06

rayane-djouah requested a review from a team as a code owner January 7, 2025 19:06

melvin-bot bot requested a review from ishpaul777 January 7, 2025 19:06

melvin-bot bot removed the request for review from a team January 7, 2025 19:06

puneetlath added the Ready To Build label Jan 7, 2025

check initial route

ec5245b

ishpaul777 reviewed Jan 7, 2025

View reviewed changes

src/pages/Search/SearchTypeMenuNarrow.tsx Outdated Show resolved Hide resolved

ishpaul777 reviewed Jan 7, 2025

View reviewed changes

src/pages/Search/SearchTypeMenuNarrow.tsx Show resolved Hide resolved

rayane-djouah added 3 commits January 7, 2025 21:13

refactor

efaca97

Merge branch 'Expensify:main' into fix-tooltip-reappears-while-creati…

3ef89c3

…ng-an-expense

Fix: inbox button tooltip appears while creating an expense from sear…

d8171c4

…ch page

thienlnam requested a review from ikevin127 January 7, 2025 23:00

ikevin127 approved these changes Jan 8, 2025

View reviewed changes

melvin-bot bot requested a review from grgia January 8, 2025 00:09

thienlnam changed the title ~~Fix: Reports - "Customize your search" tooltip reappears while creating an expense~~ [CP Stag] Fix: Reports - "Customize your search" tooltip reappears while creating an expense Jan 8, 2025

thienlnam requested review from thienlnam and removed request for grgia January 8, 2025 00:13

Expensify deleted a comment from ishpaul777 Jan 8, 2025

thienlnam approved these changes Jan 8, 2025

View reviewed changes

thienlnam merged commit 56444a5 into Expensify:main Jan 8, 2025
18 of 20 checks passed

rayane-djouah deleted the fix-tooltip-reappears-while-creating-an-expense branch January 8, 2025 00:17

github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Jan 8, 2025

github-actions bot mentioned this pull request Jan 8, 2025

Deploy Checklist: New Expensify 2025-01-06 #54825

Closed

74 tasks

melvin-bot bot mentioned this pull request Jan 8, 2025

[HOLD for payment 2025-01-15] Reports - "Customize your search" tooltip reappears while creating an expense. #54879

Open

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Stag] Fix: Reports - "Customize your search" tooltip reappears while creating an expense #54897

[CP Stag] Fix: Reports - "Customize your search" tooltip reappears while creating an expense #54897

rayane-djouah commented Jan 7, 2025 •

edited

Loading

melvin-bot bot commented Jan 7, 2025

github-actions bot commented Jan 7, 2025

github-actions bot commented Jan 7, 2025

rayane-djouah commented Jan 7, 2025 •

edited

Loading

rayane-djouah commented Jan 7, 2025 •

edited

Loading

ikevin127 commented Jan 7, 2025 •

edited

Loading

ikevin127 left a comment •

edited

Loading

thienlnam commented Jan 8, 2025

thienlnam commented Jan 8, 2025

OSBotify commented Jan 8, 2025

github-actions bot commented Jan 8, 2025

github-actions bot commented Jan 8, 2025

[CP Stag] Fix: Reports - "Customize your search" tooltip reappears while creating an expense #54897

[CP Stag] Fix: Reports - "Customize your search" tooltip reappears while creating an expense #54897

Conversation

rayane-djouah commented Jan 7, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 7, 2025

github-actions bot commented Jan 7, 2025

github-actions bot commented Jan 7, 2025

rayane-djouah commented Jan 7, 2025 • edited Loading

rayane-djouah commented Jan 7, 2025 • edited Loading

ikevin127 commented Jan 7, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

ikevin127 left a comment • edited Loading

Choose a reason for hiding this comment

thienlnam commented Jan 8, 2025

thienlnam commented Jan 8, 2025

OSBotify commented Jan 8, 2025

github-actions bot commented Jan 8, 2025

github-actions bot commented Jan 8, 2025

rayane-djouah commented Jan 7, 2025 •

edited

Loading

rayane-djouah commented Jan 7, 2025 •

edited

Loading

rayane-djouah commented Jan 7, 2025 •

edited

Loading

ikevin127 commented Jan 7, 2025 •

edited

Loading

ikevin127 left a comment •

edited

Loading