Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keyboard not dismissed #53907

Merged
merged 8 commits into from
Jan 8, 2025
Merged

fix: keyboard not dismissed #53907

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7194ed0
fix: keyboard not dismissed
daledah Dec 11, 2024
6b2da07
Merge branch 'main' into fix/53196
daledah Dec 17, 2024
dbd6f62
fix: lint
daledah Dec 17, 2024
df34a1f
Merge branch 'main' into fix/53196
daledah Dec 20, 2024
af03a2b
fix: lint-changed
daledah Dec 20, 2024
9e2bcac
Merge branch 'main' into fix/53196
daledah Dec 25, 2024
d6372b7
fix: revert lint changes
daledah Jan 7, 2025
2f94bff
Merge branch 'main' into fix/53196
daledah Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/pages/home/report/PureReportActionItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import lodashIsEqual from 'lodash/isEqual';
import React, {memo, useCallback, useContext, useEffect, useMemo, useRef, useState} from 'react';
import type {GestureResponderEvent, TextInput} from 'react-native';
import {InteractionManager, View} from 'react-native';
import {InteractionManager, Keyboard, View} from 'react-native';
import type {OnyxEntry} from 'react-native-onyx';
import type {ValueOf} from 'type-fest';
import type {Emoji} from '@assets/emojis/types';
Expand Down Expand Up @@ -1075,7 +1075,15 @@ function PureReportActionItem({
return (
<PressableWithSecondaryInteraction
ref={popoverAnchorRef}
onPress={draftMessage === undefined ? onPress : undefined}
onPress={() => {
if (draftMessage === undefined) {
onPress?.();
}
if (!Keyboard.isVisible()) {
return;
}
Keyboard.dismiss();
}}
style={[action.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE && !isDeletedParentAction ? styles.pointerEventsNone : styles.pointerEventsAuto]}
onPressIn={() => shouldUseNarrowLayout && DeviceCapabilities.canUseTouchScreen() && ControlSelection.block()}
onPressOut={() => ControlSelection.unblock()}
Expand Down
Loading