-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] Hybrid - Android - Chat – App reloads/crashes when select an emoji from suggestions list #55019
Comments
Triggered auto assignment to @kadiealexander ( |
Triggered auto assignment to @rlinoz ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Production 1.mp4 |
I can repro, so looking |
@WoLewicki is also looking for a bit. |
Thanks, I am having a hard time building hybrid |
I was also trying to build Android in Hybrid for like an hour now and failed. Not sure if something weird was merged, but it fails with |
I removed Mobile-Expensify folder and started the whole process again and now it worked 😄 Edit: Actually, the build worked, but I am getting no internet connection in the app |
OK the stacktrace is pretty much that
|
I am guessing this is related to the RN update, checking that now, if confirmed I will open up for proposals so we don't have to revert it |
So I am wrong, it is not reproducible in the adhoc build from that PR |
Job added to Upwork: https://www.upwork.com/jobs/~021877460008842832724 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane ( |
Upwork job price has been updated to $500 |
https://github.com/allroundexperts/Expensify/blob/3b665f7ff38fc7b3b7155e84eb0d09e680742a82/src/pages/home/report/ReportActionCompose/SuggestionEmoji.tsx#L96 is causing the crash. It's highly probable that this was related to RN upgrade. |
@rlinoz Which build did you use to test? |
Okay. Found the issue. We are missing this commit on hybrid app. |
@rlinoz Can I raise a PR or should I post a proper proposal? |
And @mountiny a gentle bump on #54988 (comment) 😄 |
Result: Screen.Recording.2025-01-10.at.3.38.40.AM.mov |
Great catch @allroundexperts 🚀 |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: v9.0.82-4
Reproducible in staging?: Yes
Reproducible in production?: No
Issue reported by: Applause Internal Team
Device used: RealmeC67 / Android 14
Action Performed:
Expected Result:
App doesn’t reloads/crashes. Emoji is present in composer
Actual Result:
App reloads/crashes when select an emoji from suggestions list
Workaround:
Unknown
Platforms:
Screenshots/Videos
video_2025-01-09_19-21-44.mp4
View all open jobs on GitHub
logs-2025-01-09 17_03_30.307.txt
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @allroundexpertsThe text was updated successfully, but these errors were encountered: