Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Hybrid Android - App overlaps with status bar when app is killed and relaunched #54988

Open
1 of 8 tasks
IuliiaHerets opened this issue Jan 9, 2025 · 27 comments
Open
1 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Jan 9, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.82-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy Z Fold 4 / Android 14
App Component: Other

Action Performed:

  1. Launch hybrid app.
  2. Log in to a new Expensifail account.
  3. After logging in, kill the app.
  4. Relaunch the app.
  5. Kill app and relaunch app several times because sometimes app launches without issue.

Expected Result:

App will not overlap with status bar after killing app and relaunching app.

Actual Result:

App overlaps with status bar after killing app and relaunching app.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6709705_1736408700265.Bug6709620_1736396616448_Screen_Recording_20250109_122013_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021877375704795838083
  • Upwork Job ID: 1877375704795838083
  • Last Price Increase: 2025-01-09
Issue OwnerCurrent Issue Owner: @ZhenjaHorbach
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Jan 9, 2025
Copy link

melvin-bot bot commented Jan 9, 2025

Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jan 9, 2025

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Jan 9, 2025
Copy link

melvin-bot bot commented Jan 9, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@pecanoro
Copy link
Contributor

pecanoro commented Jan 9, 2025

It's happening on my pixel phone as well and it's pretty bad as it's preventing me fro using the app

@mountiny
Copy link
Contributor

mountiny commented Jan 9, 2025

@pecanoro does it happen reliably? You can still click the buttons right?

Definitely not a good UX if its shifted

Gonna ask swm to look into this

@pecanoro
Copy link
Contributor

pecanoro commented Jan 9, 2025

@mountiny I can't open the menus on the top, I am stuck, so pretty unusable

Screenshot_20250109-120515.png

@pecanoro
Copy link
Contributor

pecanoro commented Jan 9, 2025

I think it might be due to #51475 but I am not fully sure since I am having trouble testing it

@WoLewicki
Copy link
Contributor

I saw this issue some time ago while working on 0.76 so it is most probably connected. At some point I stopped seeing this so I thought that it is fixed but seems like it is just much less frequent now. But yeah, most probably #48911 is the cause.

@shubham1206agra
Copy link
Contributor

Isn't this issue old? cc @jayeshmangwani

@jayeshmangwani
Copy link
Contributor

@shubham1206agra Yes We have a similar issue when opening the app from a notification here #48190, and I can reliably reproduce that issue.

However, the current issue that occurs when opening the app normally is not reproducible on my end.

@pecanoro
Copy link
Contributor

pecanoro commented Jan 9, 2025

The problem is that forcing stopping the app doesn't fix it either. Logging out doesn't work either. So I am going to try uninstalling and installing again

@pecanoro
Copy link
Contributor

pecanoro commented Jan 9, 2025

Ok, that didn't work either, now it seems I am stuck in this state forever

@mountiny
Copy link
Contributor

mountiny commented Jan 9, 2025

Seems like the update just made it more prominent but the problem occured before. Maybe its similar root cause as with the other blocker and its a race condition. But since the upgrade of rn made things faster this could show up more often.

As this is last blocker without proposed solution and revert of rn is not desirable i am going to make this external for $500. Hopefully we can fix the issue @jayeshmangwani also mentioned

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Jan 9, 2025
@melvin-bot melvin-bot bot changed the title Hybrid Android - App overlaps with status bar when app is killed and relaunched [$250] Hybrid Android - App overlaps with status bar when app is killed and relaunched Jan 9, 2025
Copy link

melvin-bot bot commented Jan 9, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021877375704795838083

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 9, 2025
Copy link

melvin-bot bot commented Jan 9, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

@mountiny mountiny changed the title [$250] Hybrid Android - App overlaps with status bar when app is killed and relaunched [$509] Hybrid Android - App overlaps with status bar when app is killed and relaunched Jan 9, 2025
Copy link

melvin-bot bot commented Jan 9, 2025

Upwork job price has been updated to $509

@mountiny mountiny changed the title [$509] Hybrid Android - App overlaps with status bar when app is killed and relaunched [$500] Hybrid Android - App overlaps with status bar when app is killed and relaunched Jan 9, 2025
Copy link

melvin-bot bot commented Jan 9, 2025

Upwork job price has been updated to $500

@s77rt
Copy link
Contributor

s77rt commented Jan 9, 2025

Give us the $9 back

@s77rt
Copy link
Contributor

s77rt commented Jan 9, 2025

We also merged #54961 which could be related

@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Jan 9, 2025

After 10 tries, I was finally able to reproduce it on the emulator following QA steps

OR It is possible to reproduce more stable
If we completely clear the application cache and storage
And then log in again

I'll try to find the root cause tomorrow

2025-01-09.21.07.44.mov

@WoLewicki
Copy link
Contributor

Seems like some race condition at the startup for the application of StatusBar insets. We do it in OD: https://github.com/Expensify/Mobile-Expensify/blob/afeab29cd0f014ce8ce780033300ee3b18240113/Android/src/yapl/android/ReactNativeActivity.kt#L95 and some libs do the same in ND. I'd start with e.g. commenting the mentioned code and seeing if it starts to work.

@pecanoro
Copy link
Contributor

pecanoro commented Jan 9, 2025

This is coming from a comment in Slack. After trying different things, it seems the old app in the hybrid app is broken for me forever, no matter what I try. However, if I am really precise, I can open the top right menu and open the new app. What is interesting is that the new app is not always broken, and it's much harder to reproduce there, as you all mentioned.

Copy link

melvin-bot bot commented Jan 9, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@mountiny
Copy link
Contributor

mountiny commented Jan 9, 2025

No 9 dollars more for you :D

@thienlnam thienlnam added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jan 10, 2025
@thienlnam
Copy link
Contributor

Demoting this based on the internal conversation here

@pecanoro
Copy link
Contributor

@thienlnam Why though? This makes hybrid completely unusable for Android users and there is no work around

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

10 participants