-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] Hybrid Android - App overlaps with status bar when app is killed and relaunched #54988
Comments
Triggered auto assignment to @pecanoro ( |
Triggered auto assignment to @isabelastisser ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
It's happening on my pixel phone as well and it's pretty bad as it's preventing me fro using the app |
@pecanoro does it happen reliably? You can still click the buttons right? Definitely not a good UX if its shifted Gonna ask swm to look into this |
@mountiny I can't open the menus on the top, I am stuck, so pretty unusable |
I think it might be due to #51475 but I am not fully sure since I am having trouble testing it |
I saw this issue some time ago while working on |
Isn't this issue old? cc @jayeshmangwani |
@shubham1206agra Yes We have a similar issue when opening the app from a notification here #48190, and I can reliably reproduce that issue. However, the current issue that occurs when opening the app normally is not reproducible on my end. |
The problem is that forcing stopping the app doesn't fix it either. Logging out doesn't work either. So I am going to try uninstalling and installing again |
Ok, that didn't work either, now it seems I am stuck in this state forever |
Seems like the update just made it more prominent but the problem occured before. Maybe its similar root cause as with the other blocker and its a race condition. But since the upgrade of rn made things faster this could show up more often. As this is last blocker without proposed solution and revert of rn is not desirable i am going to make this external for $500. Hopefully we can fix the issue @jayeshmangwani also mentioned |
Job added to Upwork: https://www.upwork.com/jobs/~021877375704795838083 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach ( |
Upwork job price has been updated to $509 |
Upwork job price has been updated to $500 |
Give us the $9 back |
We also merged #54961 which could be related |
After 10 tries, I was finally able to reproduce it on the emulator following QA steps OR It is possible to reproduce more stable I'll try to find the root cause tomorrow 2025-01-09.21.07.44.mov |
Seems like some race condition at the startup for the application of StatusBar insets. We do it in OD: https://github.com/Expensify/Mobile-Expensify/blob/afeab29cd0f014ce8ce780033300ee3b18240113/Android/src/yapl/android/ReactNativeActivity.kt#L95 and some libs do the same in ND. I'd start with e.g. commenting the mentioned code and seeing if it starts to work. |
This is coming from a comment in Slack. After trying different things, it seems the old app in the hybrid app is broken for me forever, no matter what I try. However, if I am really precise, I can open the top right menu and open the new app. What is interesting is that the new app is not always broken, and it's much harder to reproduce there, as you all mentioned. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
No 9 dollars more for you :D |
Demoting this based on the internal conversation here |
@thienlnam Why though? This makes hybrid completely unusable for Android users and there is no work around |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.82-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy Z Fold 4 / Android 14
App Component: Other
Action Performed:
Expected Result:
App will not overlap with status bar after killing app and relaunching app.
Actual Result:
App overlaps with status bar after killing app and relaunching app.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6709705_1736408700265.Bug6709620_1736396616448_Screen_Recording_20250109_122013_Expensify.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @ZhenjaHorbachThe text was updated successfully, but these errors were encountered: