Skip to content

Commit

Permalink
Merge pull request #53106 from bernhardoj/fix/52910-make-search-lhn-s…
Browse files Browse the repository at this point in the history
…crollable

Make the whole search LHN menu scrollable
  • Loading branch information
mountiny authored Nov 26, 2024
2 parents bb4c89d + 6dff844 commit c7c7690
Showing 1 changed file with 6 additions and 8 deletions.
14 changes: 6 additions & 8 deletions src/pages/Search/SearchTypeMenu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,10 @@ function SearchTypeMenu({queryJSON, searchName}: SearchTypeMenuProps) {
const shouldShowSavedSearchesMenuItemTitle = Object.values(savedSearches ?? {}).filter((s) => s.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || isOffline).length > 0;

return (
<>
<ScrollView
onScroll={onScroll}
ref={scrollViewRef}
>
<View style={[styles.pb4, styles.mh3, styles.mt3]}>
{typeMenuItems.map((item, index) => {
const onPress = singleExecution(() => {
Expand Down Expand Up @@ -272,16 +275,11 @@ function SearchTypeMenu({queryJSON, searchName}: SearchTypeMenuProps) {
{shouldShowSavedSearchesMenuItemTitle && (
<>
<Text style={[styles.sectionTitle, styles.pb1, styles.mh3, styles.mt3]}>{translate('search.savedSearchesMenuItemTitle')}</Text>
<ScrollView
onScroll={onScroll}
ref={scrollViewRef}
>
{renderSavedSearchesSection(savedSearchesMenuItems())}
</ScrollView>
{renderSavedSearchesSection(savedSearchesMenuItems())}
<DeleteConfirmModal />
</>
)}
</>
</ScrollView>
);
}

Expand Down

0 comments on commit c7c7690

Please sign in to comment.