Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added waggledance metrics with tags for enabling filtering in datadog #282

Merged
merged 34 commits into from
Aug 23, 2023

Conversation

DhrubajyotiSadhu
Copy link
Contributor

@DhrubajyotiSadhu DhrubajyotiSadhu commented Aug 15, 2023

📝 Description: Metrics have been incorporated into Waggle Dance with the inclusion of tags, which will facilitate filtering within Datadog.

🔗 Related Issues

fixes #234

@DhrubajyotiSadhu DhrubajyotiSadhu requested a review from a team as a code owner August 15, 2023 10:57
@DhrubajyotiSadhu DhrubajyotiSadhu removed the request for review from a team August 15, 2023 13:27
@DhrubajyotiSadhu DhrubajyotiSadhu changed the title Test PR Added the metrics with tags for filtering in datadog Added waggledance metrics with tags for enabling filtering in datadog Aug 15, 2023
@massdosage
Copy link
Contributor

I have a question at a higher level - how many tags will this add to each metric? Bear in mind that Datadog calculates the cost of custom metrics (more or less) as: "metric name X host X tag" so each tag you add is going to increase your custom metric costs. I'm just checking whether this will cause a cost issue or the cardinality of the tag values will be low enough that this won't be an issue.

CHANGELOG.md Outdated Show resolved Hide resolved
@DhrubajyotiSadhu
Copy link
Contributor Author

I have a question at a higher level - how many tags will this add to each metric? Bear in mind that Datadog calculates the cost of custom metrics (more or less) as: "metric name X host X tag" so each tag you add is going to increase your custom metric costs. I'm just checking whether this will cause a cost issue or the cardinality of the tag values will be low enough that this won't be an issue.

Hi @massdosage, thanks for the question
Our costs will remain consistent since we won't be sending all these metrics to Datadog; we'll utilize EKS annotations to filter them out. Additionally, the Datadog team confirmed yesterday that the expense for having 5 metrics without tags will be equivalent to having 1 metric with 5 tags.

@DhrubajyotiSadhu DhrubajyotiSadhu merged commit 8a60557 into main Aug 23, 2023
4 checks passed
@DhrubajyotiSadhu DhrubajyotiSadhu deleted the feature/waggledance_metrics branch August 26, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve metrics by tagging the call and metastore.
7 participants