-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added waggledance metrics with tags for enabling filtering in datadog #282
Conversation
waggle-dance-core/src/main/java/com/hotels/bdp/waggledance/metrics/MonitoredAspect.java
Outdated
Show resolved
Hide resolved
waggle-dance-core/src/main/java/com/hotels/bdp/waggledance/metrics/MonitoredAspect.java
Outdated
Show resolved
Hide resolved
waggle-dance-core/src/main/java/com/hotels/bdp/waggledance/metrics/MonitoredAspect.java
Outdated
Show resolved
Hide resolved
waggle-dance-core/src/main/java/com/hotels/bdp/waggledance/metrics/MonitoredAspect.java
Outdated
Show resolved
Hide resolved
waggle-dance-core/src/main/java/com/hotels/bdp/waggledance/metrics/MonitoredAspect.java
Outdated
Show resolved
Hide resolved
waggle-dance-core/src/test/java/com/hotels/bdp/waggledance/metrics/MonitoredAspectTest.java
Outdated
Show resolved
Hide resolved
waggle-dance-core/src/test/java/com/hotels/bdp/waggledance/metrics/MonitoredAspectTest.java
Show resolved
Hide resolved
waggle-dance-core/src/test/java/com/hotels/bdp/waggledance/metrics/MonitoredAspectTest.java
Show resolved
Hide resolved
I have a question at a higher level - how many tags will this add to each metric? Bear in mind that Datadog calculates the cost of custom metrics (more or less) as: "metric name X host X tag" so each tag you add is going to increase your custom metric costs. I'm just checking whether this will cause a cost issue or the cardinality of the tag values will be low enough that this won't be an issue. |
Hi @massdosage, thanks for the question |
📝 Description: Metrics have been incorporated into Waggle Dance with the inclusion of tags, which will facilitate filtering within Datadog.
🔗 Related Issues
fixes #234