Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lint #4

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix: lint #4

wants to merge 8 commits into from

Conversation

yayacat
Copy link
Member

@yayacat yayacat commented Nov 20, 2024

No description provided.

@@ -1,3 +1,4 @@
// eslint-disable-next-line @typescript-eslint/no-extraneous-class
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不要關掉這個規則
把 class 換成一般的物件就好

@@ -1,7 +1,9 @@
const Station_Wrapper = document.querySelector('.realtime-station');
// eslint-disable-next-line @typescript-eslint/no-unused-vars
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是確定全域變數的話在 eslint.config.mjs 的 global 裡面設定,不要單獨關規則

@@ -4,6 +4,7 @@ const isDev = process.defaultApp
let TREM;

if (isDev) {
// eslint-disable-next-line @typescript-eslint/no-unused-vars
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是確定全域變數的話在 eslint.config.mjs 的 global 裡面設定,不要單獨關規則

const Station_Location = Station_Wrapper.querySelector('.location');
const Station_Select_Wrapper = Station_Wrapper.querySelector('.select-wrapper');
const Station_Local_Items = Station_Select_Wrapper.querySelector('.local');
// eslint-disable-next-line @typescript-eslint/no-unused-vars
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是確定全域變數的話在 eslint.config.mjs 的 global 裡面設定,不要單獨關規則

@@ -32,6 +34,7 @@ Location.onclick = function () {
LocationSelWrapper.classList.toggle('select-show-big');
};

// eslint-disable-next-line @typescript-eslint/no-unused-vars
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是確定全域變數的話在 eslint.config.mjs 的 global 裡面設定,不要單獨關規則

@@ -1,3 +1,4 @@
// eslint-disable-next-line @typescript-eslint/no-unused-vars
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是確定全域變數的話在 eslint.config.mjs 的 global 裡面設定,不要單獨關規則

@yayacat yayacat requested a review from kamiya10 November 21, 2024 02:19
@pull-request-size pull-request-size bot added size/S and removed size/M labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants