Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward translations to main #3012

Closed
wants to merge 1 commit into from
Closed

Forward translations to main #3012

wants to merge 1 commit into from

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented Jul 9, 2024

Using translations submitted for 0.28.3 in #2986

@kmilos kmilos requested a review from lbschenkel July 9, 2024 13:57
@kmilos kmilos added the L10n Translation languages label Jul 9, 2024
@lbschenkel
Copy link
Collaborator

I believe the translations in main are very old, so it probably won't harm just copying the strings from the branch into it.

However, just for the record, this is not the "proper" way of doing it. It would be better instead to upload the .pot from main into Crowdin, and then doing a sync, and then downloading the translations from there (with or without waiting for translators to translate more). The translations for identical or similar enough strings between branches will automatically be reused. This has the advantage of not destroying the translations for any string that only exists in main but not in other branches.

If we're going to "destroy" translations from main I can't really say, only by diffing the .pot files we can know for sure. If you want the safer route, it's better to do the way I described above.

@kmilos
Copy link
Collaborator Author

kmilos commented Jul 9, 2024

I believe the translations in main are very old, so it probably won't harm just copying the strings from the branch into it.

This is exactly what I did: I took the recent .po files from 0.28.3 and merged them w/ a refreshed exiv2.pot from main. Old catalogs were not part of the process.

I suppose I could also use msgcat on the old main catalogs and the 0.28.3 ones first, and then refresh against the main exiv2.pot, that sound better?

Where you go from here is up to you (or some other L10N champion), as I already mentioned.

@kmilos
Copy link
Collaborator Author

kmilos commented Jul 9, 2024

Hm, not entirely happy how msgcat works OOTB, have to play w/ the options...

But should be able to push a better version combining both old main and new 0.28.x translations, converting to draft for now.

Thanks for the feedback!

@kmilos kmilos marked this pull request as draft July 9, 2024 16:17
@lbschenkel
Copy link
Collaborator

I took the liberty of doing another PR: #3013

@kmilos kmilos closed this Jul 10, 2024
@kmilos kmilos deleted the kmilos/l10n_forward branch July 10, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L10n Translation languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants