-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try to fix brotli test #2763
try to fix brotli test #2763
Conversation
Signed-off-by: Rosen Penev <[email protected]>
ping @Biswa96 seems to be a regression in at least the UCRT package. |
Which test are you asking about? Multiple tests failed here. |
Look at other recent PRs |
This PR fixes the test in ucrt64. But I can not figure out who is wrong here - exiv2 or brotli. Does any CI job use brotli 1.1.0 ? @kmilos may provide some info. |
CL_SPACE should be the correct value. I don't know if this is an msys bug or upstream. |
It does for the UCRT64 job: https://github.com/Exiv2/exiv2/actions/runs/6140387211/job/16659286923#step:3:195 The Cygwin one is still on 1.0.9: https://github.com/Exiv2/exiv2/actions/runs/6140387211/job/16659286365#step:4:155 |
Looks like this failed on Linux as well in #2762? |
So upstream bug. |
Pinged upstream, looks like this is expected behaviour now from 1.1.0... So we need to either detect the brotli version, and/or check both return values 😞 |
No description provided.