Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jpgimage: small doc fix #2754

Merged
merged 1 commit into from
Sep 5, 2023
Merged

jpgimage: small doc fix #2754

merged 1 commit into from
Sep 5, 2023

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Sep 5, 2023

No description provided.

@neheb
Copy link
Collaborator Author

neheb commented Sep 5, 2023

> git grep //\!\< | wc -l
595
> git grep ///\< | wc -l
65

probably should have a consistent style. @kmilos what do you think?

@kmilos
Copy link
Collaborator

kmilos commented Sep 5, 2023

probably should have a consistent style

Sure, why not. Is it really only a plain comment, i.e. not used for some doc generation or other introspection?

Btw, there is also

$ git grep //\< | wc -l
70

@neheb
Copy link
Collaborator Author

neheb commented Sep 5, 2023

yes. I changed to ///! from //<! as that's what clang suggested. turns out the issue is < and ! being reversed.

@ghost
Copy link

ghost commented Sep 5, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #2754 (77b0ae1) into main (a93329b) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2754   +/-   ##
=======================================
  Coverage   63.91%   63.91%           
=======================================
  Files         103      103           
  Lines       22323    22323           
  Branches    10812    10812           
=======================================
  Hits        14268    14268           
  Misses       5832     5832           
  Partials     2223     2223           
Files Changed Coverage Δ
src/asfvideo.cpp 52.73% <ø> (ø)
src/basicio.cpp 50.46% <ø> (ø)
src/bmffimage.cpp 73.11% <ø> (ø)
src/convert.cpp 52.35% <ø> (ø)
src/futils.cpp 73.09% <ø> (ø)
src/jpgimage.cpp 68.91% <ø> (ø)
src/makernote_int.hpp 100.00% <ø> (ø)
src/tiffimage_int.hpp 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@neheb neheb merged commit fa41d9d into Exiv2:main Sep 5, 2023
58 checks passed
@neheb neheb deleted the docc branch September 5, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants