Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove useless code #2733

Closed
wants to merge 1 commit into from
Closed

remove useless code #2733

wants to merge 1 commit into from

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Aug 3, 2023

UCRT has obsoleted all of this

@ghost
Copy link

ghost commented Aug 3, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #2733 (8ccd183) into main (4dfb781) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

❗ Current head 8ccd183 differs from pull request most recent head 908e6eb. Consider uploading reports for the commit 908e6eb to get more accurate results

@@           Coverage Diff           @@
##             main    #2733   +/-   ##
=======================================
  Coverage   63.91%   63.91%           
=======================================
  Files         103      103           
  Lines       22313    22313           
  Branches    10804    10804           
=======================================
  Hits        14261    14261           
  Misses       5828     5828           
  Partials     2224     2224           
Files Changed Coverage Δ
app/actions.cpp 67.62% <ø> (ø)
app/exiv2.cpp 62.72% <ø> (ø)
src/basicio.cpp 50.52% <ø> (ø)

@neheb neheb force-pushed the jfm branch 3 times, most recently from 60d477c to 8ccd183 Compare August 3, 2023 04:02
UCRT has obsoleted all of this

Signed-off-by: Rosen Penev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant