-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github CI: remove tags from container names #2728
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2728 +/- ##
==========================================
+ Coverage 63.89% 63.91% +0.01%
==========================================
Files 103 103
Lines 22313 22313
Branches 10799 10806 +7
==========================================
+ Hits 14258 14261 +3
+ Misses 5830 5828 -2
+ Partials 2225 2224 -1
|
d59c2ee
to
52e7928
Compare
@Ryanf55 see last commit as an example of how to try to fix this garbage with this bug in place. Way too much code needs to be written(missing overridden destructors, same needs to be done with static const, etc...). |
Not clear - are you asking me to fix it everywhere? I don't have time other than the bare minimum. We're using Linux with 3.27 CMake and it compiles fine with all the patches I put in, so that's about all I can support here. Just a note = If the link error was caused by upgrading CMake, you could set the corresponding CMake policy to preserve <=3.26 behavior, if there's a policy for it. That would affect the whole build, and buy you some time. |
No I was pointing out that fixing it this way is impractical. The other PR has a normal fix. |
Best to be latest. Signed-off-by: Rosen Penev <[email protected]>
No description provided.