Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update canon tags 2 #2087

Merged
merged 46 commits into from
Feb 16, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
2329306
work on canon tags
alexvanderberkel May 10, 2021
f41e7e5
second rund
alexvanderberkel May 10, 2021
081f458
update tags ID
alexvanderberkel May 11, 2021
5f2dee4
update canonrf tags, new lenses
alexvanderberkel May 17, 2021
b589ced
update to tags
alexvanderberkel May 19, 2021
3ffe993
Decoding of Canon HDRInfo tag
hassec May 19, 2021
80d67b8
Adding Ambience Selection to tag list
alexvanderberkel May 19, 2021
e2b1028
Adding tag Canon AFMicroAdj
alexvanderberkel May 19, 2021
524b33e
Canon MultiExposure tag added
alexvanderberkel May 19, 2021
8b17490
Adding Canon Lighting Optimization Tag
alexvanderberkel May 19, 2021
d6f1f7c
Adding of Canon Vignetting Correction Tag 2
alexvanderberkel May 19, 2021
e3311b9
canon filter options
alexvanderberkel May 19, 2021
56a4554
Adding LensSerialNumber Tag
alexvanderberkel May 19, 2021
cf36fea
Adding Canon AF Config Tag
alexvanderberkel May 19, 2021
5cc52fe
Adding Canon RawBurst Tag
alexvanderberkel May 19, 2021
b70a3fb
Canon AF Info 2 Tag
alexvanderberkel May 19, 2021
c6b8be5
wrong brackets fixed
alexvanderberkel Feb 3, 2022
5039071
fix wrong brackets
alexvanderberkel Feb 3, 2022
5e2c84a
fix of tests case test_issue_981.py
alexvanderberkel Feb 3, 2022
3e0d9a8
fix of test_issue_1151.py
alexvanderberkel Feb 3, 2022
55de9f4
fix test_issue_1122.py
alexvanderberkel Feb 3, 2022
d72ca68
ExposureCompensation added
alexvanderberkel Feb 7, 2022
6e35cf9
Exif.Canon.CanonFlashInfo
alexvanderberkel Feb 7, 2022
378041a
Exif.CanonCs.SpotMeteringMode
alexvanderberkel Feb 7, 2022
3c7c12f
Exif.CanonCs.PhotoEffect
alexvanderberkel Feb 7, 2022
d29a09e
Exif.CanonSi.NDFilter
alexvanderberkel Feb 7, 2022
eb5221e
Exif.CanonSi.SelfTimer2
alexvanderberkel Feb 7, 2022
58fd86f
Exif.Canon.CanonFlashInfo
alexvanderberkel Feb 7, 2022
372f65e
Exif.CanonSi.FlashOutput
alexvanderberkel Feb 7, 2022
ea57df5
Exif.CanonSi.NDFilter
alexvanderberkel Feb 7, 2022
1afeea0
fix test cases
alexvanderberkel Feb 7, 2022
5f96ff0
adding exposurecompensation
alexvanderberkel Feb 8, 2022
5800942
OpticalZoomCode added
alexvanderberkel Feb 8, 2022
df29a76
fix typo Optical Zoom Code
alexvanderberkel Feb 8, 2022
b0cb14a
adding OpticalZoomCode
alexvanderberkel Feb 8, 2022
f247014
AEB Bracket Value added
alexvanderberkel Feb 8, 2022
4977b7d
controlmode added
alexvanderberkel Feb 8, 2022
de036b2
Fix remaining wrong brackets
piponazo Feb 9, 2022
e625f33
Include CanonFlashInfo (somehow missing after cherry-picking)
piponazo Feb 9, 2022
d19e2d4
Use AutoRotate
piponazo Feb 9, 2022
e1889e3
Fixing tests. test_issue_981.py is now running all 6 commands. The …
clanmills Feb 10, 2022
800ed89
Rewire Canon MakerNote 0x0026 (AFInfo) to allow TiffDecoder::decodeCa…
clanmills Feb 11, 2022
ad424df
Fixing test following Christoph's Review. (Christoph is one clever M…
clanmills Feb 11, 2022
0aa34c3
fix(canon): cleanup canonAf2 and canonAf3 related code
hassec Feb 11, 2022
72b1e22
Update tag docs with Canon groups
postscript-dev Feb 15, 2022
2f135f7
Fix regressionTests with modified reference files. `cp test/tmp/* te…
clanmills Feb 15, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion doc/templates/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,20 @@ TABLES = Exif \
CanonSi \
CanonCf \
CanonPi \
CanonTi \
CanonFi \
CanonPa \
CanonPr \
CanonTi \
CanonMe \
CanonHdr \
CanonVigCor2 \
CanonLiOp \
CanonAfMiAdj \
CanonLe \
CanonAm \
CanonFil \
CanonAfC \
CanonRawB \
Casio \
Casio2 \
Fujifilm \
Expand Down
52 changes: 51 additions & 1 deletion doc/templates/tags-canon.html.in
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,66 @@ __CanonCf__
__CanonPi__
<br>

<h3>Canon File Info Tags</h3>
<h3>Canon Filter Info Tags</h3>
<p>Click on a column header to sort the table.</p>
__CanonFi__
<br>

<h3>Canon High Dynamic Range Tags</h3>
<p>Click on a column header to sort the table.</p>
__CanonHdr__
<br>

<h3>Canon Vignetting Correction 2 Tags</h3>
<p>Click on a column header to sort the table.</p>
__CanonVigCor2__
<br>

<h3>Canon Lighting Option Tags</h3>
<p>Click on a column header to sort the table.</p>
__CanonLiOp__
<br>

<h3>Canon AF Micro Adjust Tags</h3>
<p>Click on a column header to sort the table.</p>
__CanonAfMiAdj__
<br>

<h3>Canon Lens Info Tags</h3>
<p>Click on a column header to sort the table.</p>
__CanonLe__
<br>

<h3>Canon Ambience Selection Tags</h3>
<p>Click on a column header to sort the table.</p>
__CanonAm__
<br>

<h3>Canon Filter Info Tags</h3>
<p>Click on a column header to sort the table.</p>
__CanonFil__
<br>

<h3>Canon Processing Info Tags</h3>
<p>Click on a column header to sort the table.</p>
__CanonPr__
<br>

<h3>Canon Multi-Exposure Tags</h3>
<p>Click on a column header to sort the table.</p>
__CanonMe__
<br>

<h3>Canon AF Config Tags</h3>
<p>Click on a column header to sort the table.</p>
__CanonAfC__
<br>

<h3>Canon Raw Burst Info Tags</h3>
<p>Click on a column header to sort the table.</p>
__CanonRawB__
<br>

<h3>Canon TimeInfo Tags</h3>
<p>Click on a column header to sort the table.</p>
__CanonTi__
Expand Down
12 changes: 6 additions & 6 deletions man/man1/exiv2.1
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
The Exiv2 manpage is available online.
.sp 1
.nf
Latest release: https://www.exiv2.org/manpage.html
Github 'main': https://github.com/Exiv2/exiv2/blob/main/exiv2.md
.fi
The Exiv2 manpage is available online.
.sp 1
.nf
Latest release: https://www.exiv2.org/manpage.html
Github 'main': https://github.com/Exiv2/exiv2/blob/main/exiv2.md
.fi
2 changes: 1 addition & 1 deletion samples/taglist.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ int main(int argc, char* argv[])
if (rc || bHelp) {
std::cout << "Usage: taglist [--help]" << std::endl
<< " [--group name|" << std::endl
<< " Groups|Exif|Canon|CanonCs|CanonSi|CanonCf|Fujifilm|Minolta|Nikon1|Nikon2|Nikon3|Olympus|" << std::endl
<< " Groups|Exif|Canon|CanonCs|CanonSi|CanonCf|CanonHdr|Fujifilm|Minolta|Nikon1|Nikon2|Nikon3|Olympus|" << std::endl
<< " Panasonic|Pentax|Sigma|Sony|Iptc|" << std::endl
<< " dc|xmp|xmpRights|xmpMM|xmpBJ|xmpTPg|xmpDM|pdf|photoshop|crs|tiff|exif|aux|iptc|all|ALL" << std::endl
<< " ]" << std::endl
Expand Down
183 changes: 89 additions & 94 deletions src/canonmn_int.cpp

Large diffs are not rendered by default.

14 changes: 1 addition & 13 deletions src/canonmn_int.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,6 @@ namespace Exiv2 {
static const TagInfo* tagListMv();
//! Return read-only list of built-in Canon My Colors Info tags
static const TagInfo* tagListMc();
//! Return read-only list of built-in Canon AFInfo3 Info tags
static const TagInfo* tagListAf3();
//! Return read-only list of built-in Canon Face detection Info tags
static const TagInfo* tagListFcd3();
//! Return read-only list of built-in Canon White balance Info tags
Expand Down Expand Up @@ -123,15 +121,7 @@ namespace Exiv2 {
static const TagInfo* tagListAfC();
//! Return read-only list of built-in Canon RawBurstInfo Info tags
static const TagInfo* tagListRawB();
//! Return read-only list of built-in Canon AFInfo2 Info tags
static const TagInfo* tagListAf2();









//! @name Print functions for Canon %MakerNote tags
//@{
Expand Down Expand Up @@ -182,8 +172,6 @@ namespace Exiv2 {

//! Tag information
static const TagInfo tagInfo_[];
static const TagInfo tagInfoAf2_[];
static const TagInfo tagInfoAf3_[];
static const TagInfo tagInfoAfC_[];
static const TagInfo tagInfoAfMiAdj_[];
static const TagInfo tagInfoAm_[];
Expand Down
1 change: 1 addition & 0 deletions src/exif.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -712,6 +712,7 @@ namespace Exiv2 {
"Exif.Canon.AFPointsInFocus",
"Exif.Canon.AFPointsSelected",
"Exif.Canon.AFPointsUnusable",
"Exif.Canon.AFFineRotation",
};
for (auto&& filteredIfd0Tag : filteredIfd0Tags) {
auto pos = ed.findKey(ExifKey(filteredIfd0Tag));
Expand Down
10 changes: 10 additions & 0 deletions src/tags_int.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,16 @@ namespace Exiv2 {
{ canonFiId, "Makernote", "CanonFi", CanonMakerNote::tagListFi },
{ canonPaId, "Makernote", "CanonPa", CanonMakerNote::tagListPa },
{ canonPrId, "Makernote", "CanonPr", CanonMakerNote::tagListPr },
{ canonVigCor2Id, "Makernote", "CanonVigCor2", CanonMakerNote::tagListVigCor2 },
{ canonLiOpId, "Makernote", "CanonLiOp", CanonMakerNote::tagListLiOp },
{ canonAfMiAdjId, "Makernote", "CanonAfMiAdj", CanonMakerNote::tagListAfMiAdj },
{ canonLeId, "Makernote", "CanonLe", CanonMakerNote::tagListLe },
{ canonAmId, "Makernote", "CanonAm", CanonMakerNote::tagListAm },
{ canonFilId, "Makernote", "CanonFil", CanonMakerNote::tagListFil },
{ canonMeId, "Makernote", "CanonMe", CanonMakerNote::tagListMe },
{ canonHdrId, "Makernote", "CanonHdr", CanonMakerNote::tagListHdr },
{ canonAfCId, "Makernote", "CanonAfC", CanonMakerNote::tagListAfC },
{ canonRawBId, "Makernote", "CanonRawB", CanonMakerNote::tagListRawB },
{ casioId, "Makernote", "Casio", CasioMakerNote::tagList },
{ casio2Id, "Makernote", "Casio2", Casio2MakerNote::tagList },
{ fujiId, "Makernote", "Fujifilm", FujiMakerNote::tagList },
Expand Down
4 changes: 1 addition & 3 deletions src/tags_int.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,6 @@ namespace Exiv2 {
panaRawId,
mnId,
canonId,
canonAf2Id,
canonAf3Id,
canonAfCId,
canonAfMiAdjId,
canonAmId,
Expand Down Expand Up @@ -96,7 +94,7 @@ namespace Exiv2 {
canonTiId,
canonFiId,
canonPrId,
canonPreID,
canonPreID,
canonVigCorId,
canonVigCor2Id,
canonWbId,
Expand Down
Loading