Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: MicroHID Dynamic Spawn Location Fixes (Plus LCZ Cafe Fix) #369

Closed
wants to merge 1 commit into from

Conversation

SnivyFilms
Copy link

@SnivyFilms SnivyFilms commented Jan 3, 2025

Description

Describe the changes
Due to the 14.0 update releasing, InsideHid, InsideHidLeft, and InsideHidRight broke due to the proper doors being renamed to HID_CHAMBER, HID_LOWER, and HID_UPPER. These changes fixes that issue, and for HID_UPPER has a reverse door setup so the items spawns in the room that you enter after you go up the stairs. HID_CHAMBER and HID_LOWER do not need this.

For a long while if you tried to use InsideLczCafe (PC-15) the spawn position will be outside in the hall and not in the room, a reverse location for this spawn position has been added.

What is the current behavior? (You can also link to an open issue here)
Micro HID Dynamic Spawn Points are broken.
InsideLczCafe did not put you inside PC-15

What is the new behavior? (if this is a feature change)
Micro HID Dynamic Spawn Points works again
InsideLczCafe will put you inside PC-15

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Due to renaming enums, if a project (re)compiles with the old InsideHid references it will not be found

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@github-actions github-actions bot added the API label Jan 3, 2025
@Misfiy Misfiy added bug Something isn't working breaking-changes labels Jan 3, 2025
@Misfiy
Copy link
Member

Misfiy commented Jan 3, 2025

Renames enums, causing compile error, but no breaking existing plugins other than trying to recompile

@SnivyFilms SnivyFilms changed the title fix: MicroHID Dynamic Spawn Location Fixes (Plus LCZ Cafe Fix) fix!: MicroHID Dynamic Spawn Location Fixes (Plus LCZ Cafe Fix) Jan 3, 2025
@SnivyFilms
Copy link
Author

My brain is small and smooth, Im remaking this PR but to target dev branch, mb

@SnivyFilms SnivyFilms closed this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API breaking-changes bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants