Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new properties to Hume Shield #296

Closed
wants to merge 2 commits into from

Conversation

ITeMbI4
Copy link

@ITeMbI4 ITeMbI4 commented Dec 2, 2024

Description

Describe the changes

  • Add new properties to Hume Shield
  • A bit of code cleanup

What is the current behavior? (You can also link to an open issue here)

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

Copy link
Member

@Misfiy Misfiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contribute to #130 instead of duplicate PR

@ITeMbI4
Copy link
Author

ITeMbI4 commented Dec 3, 2024

-_-

@ITeMbI4 ITeMbI4 closed this Dec 3, 2024
@ITeMbI4 ITeMbI4 deleted the MaxHumeShield branch December 3, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants