Adapt to new Hammer API #36
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruslandoga
commented
Nov 15, 2024
|
|
||
| case :mnesia.create_table(table, mnesia_opts) do | ||
| {:atomic, :ok} -> :ok | ||
| {:aborted, {:already_exists, _}} -> :ok |
There was a problem hiding this comment.
Not sure what to do about this. Technically we should raise, but raising here would bring down the supervisor and then the whole application since it would hit 5 restarts per 3 seconds very quickly.
There was a problem hiding this comment.
I mean if you can t start it and is needed that seems like an issue?
There was a problem hiding this comment.
That's not what this is about. What you are asking about is probably the next line below that one, 129.
This is about a table that might exist but have a different structure.
ruslandoga
force-pushed
the
new-hammer
branch
from
16f7fcf
to
b6372f7
Compare
ruslandoga
force-pushed
the
new-hammer
branch
from
b6372f7
to
84e5b8a
Compare
epinault
reviewed
Nov 15, 2024
epinault
reviewed
Nov 15, 2024
epinault
reviewed
Nov 15, 2024
epinault
reviewed
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: ExHammer/hammer#104
It's kind of hard to get the distributed configuration right. It should probably be documented. I'll play around with Mnesia on the weekend and maybe update the README with a working ram_copies setup. But I think this PR is good to go. The previous version wasn't distributed by default either.