address comments
Codecov / codecov/project
succeeded
Dec 20, 2024 in 0s
78.00% (+0.15%) compared to ae74c10
View this Pull Request on Codecov
78.00% (+0.15%) compared to ae74c10
Details
Codecov Report
Attention: Patch coverage is 92.55583% with 30 lines in your changes missing coverage. Please review.
Project coverage is 78.00%. Comparing base (
ae74c10) to head (cf2e504).
Report is 5 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/daft-logical-plan/src/ops/set_operations.rs | 87.04% | 25 Missing |
| src/daft-functions/src/list/list_fill.rs | 96.47% | 5 Missing |
Additional details and impacted files
@@ Coverage Diff @@
## main #3537 +/- ##
==========================================
+ Coverage 77.84% 78.00% +0.15%
==========================================
Files 718 720 +2
Lines 88250 88778 +528
==========================================
+ Hits 68696 69247 +551
+ Misses 19554 19531 -23 | Files with missing lines | Coverage Δ | |
|---|---|---|
| daft/dataframe/dataframe.py | 85.47% <100.00%> (+0.18%) |
⬆️ |
| daft/logical/builder.py | 90.22% <100.00%> (+0.53%) |
⬆️ |
| src/daft-core/src/array/ops/list.rs | 95.32% <100.00%> (+0.22%) |
⬆️ |
| src/daft-core/src/series/ops/list.rs | 63.47% <100.00%> (+0.66%) |
⬆️ |
| src/daft-logical-plan/src/builder.rs | 92.22% <100.00%> (+0.09%) |
⬆️ |
| src/daft-functions/src/list/list_fill.rs | 96.47% <96.47%> (ø) |
|
| src/daft-logical-plan/src/ops/set_operations.rs | 72.82% <87.04%> (+37.78%) |
⬆️ |
Loading