Skip to content

encapsulate the task in a struct, map_err to dafterror

Codecov / codecov/project succeeded Oct 31, 2024 in 0s

78.89% (+0.26%) compared to 5b450fb

View this Pull Request on Codecov

78.89% (+0.26%) compared to 5b450fb

Details

Codecov Report

Attention: Patch coverage is 96.07843% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.89%. Comparing base (5b450fb) to head (ab26801).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
src/common/runtime/src/lib.rs 97.72% 1 Missing ⚠️
src/daft-local-execution/src/sources/scan_task.rs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3128      +/-   ##
==========================================
+ Coverage   78.62%   78.89%   +0.26%     
==========================================
  Files         621      624       +3     
  Lines       74125    75973    +1848     
==========================================
+ Hits        58284    59938    +1654     
- Misses      15841    16035     +194     
Files with missing lines Coverage Δ
...-execution/src/intermediate_ops/intermediate_op.rs 82.16% <ø> (+2.43%) ⬆️
...rc/daft-local-execution/src/sinks/blocking_sink.rs 74.39% <100.00%> (ø)
...c/daft-local-execution/src/sinks/streaming_sink.rs 83.55% <100.00%> (ø)
src/daft-scan/src/glob.rs 88.96% <100.00%> (-0.04%) ⬇️
src/common/runtime/src/lib.rs 90.78% <97.72%> (+2.18%) ⬆️
src/daft-local-execution/src/sources/scan_task.rs 72.50% <0.00%> (ø)

... and 81 files with indirect coverage changes